target.actual-name is an ideal cache key because it is already used to register targets in the build engine which requires on it to be unique enough to not collide, while also is the shortest unique identifying string which is for a file targets consists of the target relevant properties, path prefix and name.
This simplification also makes it easy to port register/recent-targets/clear-recent-targets/all-targets to native which probably will have a significant impact too (at least on these 8 seconds virtual-target.register self time).
total 79.2 -> 13.2 (6.0x) self 34.2 -> 8.1 (4.2x)
target.actual-name
is an ideal cache key because it is already used to register targets in the build engine which requires on it to be unique enough to not collide, while also is the shortest unique identifying string which is for a file targets consists of the target relevant properties, path prefix and name.This simplification also makes it easy to port
register/recent-targets/clear-recent-targets/all-targets
to native which probably will have a significant impact too (at least on these 8 secondsvirtual-target.register
self time).