Closed Lastique closed 6 months ago
I wanted to ping this, as I believe it blocks the 1.85 release.
@teeks99 it doesn't block the release as the error output does not affect actual operation. It's just unsightly, AFAIK.
it doesn't block the release as the error output does not affect actual operation. It's just unsightly, AFAIK.
I guess that is true for msvc-14.1+, however for msvc-14.0 that is less clear. This appears (and I'm not clear what I'm looking at, so maybe this is just a noisy log) to cause an issue in wave. log
At the very least, this makes it annoyingly hard to see if there were other errors during the build.
Regardless of its blocking status, it would definitely be nice to get into 1.85. Is this the plan?
it doesn't block the release as the error output does not affect actual operation. It's just unsightly, AFAIK.
I guess that is true for msvc-14.1+, however for msvc-14.0 that is less clear. This appears (and I'm not clear what I'm looking at, so maybe this is just a noisy log) to cause an issue in wave. log
In that, it still completes building everything without build errors of any targets (at the end it doesn't say it failed or skipped targets).
At the very least, this makes it annoyingly hard to see if there were other errors during the build.
Right.
Regardless of its blocking status, it would definitely be nice to get into 1.85. Is this the plan?
Working on it.
Proposed changes
This eliminates majority of comments that look like
#include
directives. One practical example is a comment in Boost.Wave that has#include <>
and#include ""
in its body.This issue came up during Boost 1.85 release preparation.
Types of changes
Checklist