cmd.exe quirk 1: exit /b 1 sets error code 0 for the process, even though it sets errorlevel to 1.
bootstrap.bat needs to check that build.bat succeded (cmd.exe quirk 2: echo off doesn't change errorlevel).
build.bat overrides exit code with call to dir *.exe.
setlocal will rollback pushd on exit (that also helps with Ctrl+C).
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other (please describe):
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[ ] I added myself to the copyright attributions for significant changes
[ ] I checked that tests pass locally with my changes
[ ] I added tests that prove my fix is effective or that my feature works
[ ] I added necessary documentation (if appropriate)
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
exit /b 1sets error code0for the process, even though it setserrorlevelto1.bootstrap.batneeds to check thatbuild.batsucceded (cmd.exe quirk 2:echo offdoesn't changeerrorlevel).build.batoverrides exit code with call todir *.exe.setlocalwill rollbackpushdon exit (that also helps with Ctrl+C).Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...