bfgroup / b2

B2 makes it easy to build C++ projects, everywhere.
https://www.bfgroup.xyz/b2/
Boost Software License 1.0
75 stars 228 forks source link

Fix using relevant features in ac module #375

Closed grisumbras closed 4 months ago

grisumbras commented 4 months ago

Proposed changes

The rule configure.get-relevant-features was misnamed, as it returned relevant properties, not features. The misnomer seems to had been the source of misuse: ac module did not consider any feature other than <link> to be relevant when checking for library existance. That could result in incorrect config checks.

The change renames the rule to get-relevant-properties, and adds back get-relevant-features that returns features. In addition, it fixes the usage of get-relevant-features in ac module (it called the rule without arguments), and removes another usage where its invocation could not result in anything meaningful.

Types of changes