search

bfifield / hettx

hettx: Detecting and Measuring Treatment Effect Variation
9 stars 0 forks source link

Better names! #10

Closed bfifield closed 5 years ago

bfifield commented 5 years ago

I think we're all on the same page that the package/some of the function names can be better. I'm on board with fishpidetect for the Fisherian methods, but maybe est.beta could be more informative for the systematic estimation methods? No current ideas for what it should be. Also, for the package name - FRTCI no longer completely describes all of the functionalities in the package. Maybe detect.hetfx? Open to other ideas too.

lmiratrix commented 5 years ago

how about estimate.systematic and detect.idiosyncratic

for package does 'hettx' exist? Or, to be cutsy, 'fisherman' but perhaps not.

  --> Due to my RSI (wrist trouble), e-mail often abrupt <--

On Sat, Nov 24, 2018 at 12:48 PM Ben Fifield notifications@github.com wrote:

I think we're all on the same page that the package/some of the function names can be better. I'm on board with fishpidetect for the Fisherian methods, but maybe est.beta could be more informative? No current ideas for what it should be. Also, for the package name - FRTCI no longer completely describes all of the functionalities in the package. Maybe detect.hetfx? Open to other ideas too.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bfifield/detect_heteffects/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHt5TlZUgsgTMuagU5hz0ASm4F8CKUEks5uyYaHgaJpZM4YxhXI .

bfifield commented 5 years ago

Yep, these sound good to me. And hettx for the package name definitely works - I think also useful to signal that the methods specifically deal with het treatment effects, which fisherman doesn't do (although I do like it!). I'll bring these into the existing pull request for the est.beta wrapper.