bfintal / Counter-Up

Counter-Up is a lightweight jQuery plugin that counts up to a targeted number when the number becomes visible.
http://bfintal.github.io/Counter-Up/demo/demo.html
GNU General Public License v2.0
746 stars 719 forks source link

Error on parseInt #68

Open alemachado opened 5 years ago

alemachado commented 5 years ago

When used the number "1,990", the script generates "1,989". That's why on the list generation of incremental numbers to display, when it calls the operation to preserve as int if input was int, it uses "parseInt": (row 54 : var newNum = Math.round(num / divisions * i);)

(1990 / 100 100) = 1989.9999999999998 parseInt(1990 / 100 100) = 1989

the script should use instead Math.round Math.round(1990 / 100 * 100) = 1990