bflad / chef-stash

Chef Cookbook for Atlassian Stash
Other
37 stars 42 forks source link

Investigate infrataster for testing http responses after setup #109

Open patcon opened 9 years ago

patcon commented 9 years ago

Not sure whether it's right for us, but with looking into, since serverspec just lets us check whether ports are listening, but no concise way to check responses

linc01n commented 9 years ago

Would it take too long for the test? you know java takes forever to start.

patcon commented 9 years ago

Probably right. I think it takes like 3 minutes to start in my VM's... but I suppose just testing for that loading screen might be good enough to know things are working out. But maybe that's not worth adding a dependency over... heh

bflad commented 9 years ago

It's an interesting idea. When I was testing Stash via just Vagrant, I always went through the whole initial setup flow for each OS to ensure it was actually setting up everything correctly so that Stash was completely usable. However from my observations in the past, I'd say you're probably okay with just testing the port since I'm sure the initial workflow will change over time as the product changes and I'm sure there's much more important problems to solve.

bflad commented 9 years ago

Now, that said, we have issues testing today like #99 and the LWRPs in general. Personally I'd feel more comfortable changing the LWRPs with tests added when there's a fully setup and running Stash instance for which we can send API requests.

ramonskie commented 8 years ago

infratester does not have any test-kitchen intergration so when you set this up you need to have static ips