search

bflad / chef-stash

Chef Cookbook for Atlassian Stash
Other
37 stars 42 forks source link

Adding the ability to append query strings to the on jdbc urls #161

Closed ghost closed 8 years ago

ghost commented 8 years ago

This is for a feature request, issue #159. This creates a new attribute in the name space ['stash']['database']['query_string'] where the attribute is a string. The string is appended to the end of the jdbc url for things like encrypting the connection to the database via SSL. The feature is for postgresql, mysql, and sqlserver. The default value for the attribute is an empty string.

ghost commented 8 years ago

Fixed the rubocop errors. Is there any way to start a new build?

linc01n commented 8 years ago

Thanks for the pull request. I have merged it to master. I made a few changes due to conflict, missing test and data-bag handling.

https://github.com/bflad/chef-stash/blob/eadae4319b2c41ba041177908c7a78ab5cefb11d/libraries/stash.rb#L26 https://github.com/bflad/chef-stash/blob/eadae4319b2c41ba041177908c7a78ab5cefb11d/spec/database_spec.rb#L34 https://github.com/bflad/chef-stash/blob/eadae4319b2c41ba041177908c7a78ab5cefb11d/spec/database_spec.rb#L80