bflad / chef-stash

Chef Cookbook for Atlassian Stash
Other
37 stars 42 forks source link

Recipe doesn't install java #85

Open drrk opened 9 years ago

drrk commented 9 years ago

Even though the cookbook depends on the java cookbook, and the testing recipe include the java cookbook default recipe, the main cookbook doesn't install java, but depends on java to be installed.

linc01n commented 9 years ago

The java cookbook let you install 2 flavor of java. openjdk and the proprietary one. Which one you think we should include?

patcon commented 9 years ago

Because of the wealth of config options for java, most cookbooks seem to leave it out and just document the need to add it. I would rather we did this rather than be opinionated about overrides

bflad commented 9 years ago

Ideologically I'm in agreement with @patcon on this fortunately or unfortunately. While our testing framework will provide its own defaults to be usable in enough capacity to run the tests, I don't think we should dictate or want to wrap the Java configuration for everyone's environment. If we were to go down that route though, I'd suggest something like a "manage_java" attribute, separate java recipe, and new java attributes.

cloneluke commented 7 years ago

berksfile: cookbook 'java'

recipe:

need to do java install, it was assumed in supermarket cookbook

node.default['java']['jdk_version'] = '8' ENV['JAVA_HOME'] = '/usr/lib/jvm/java-8-openjdk-amd64' include_recipe 'java::default'