v0.28.0 "// lintignore" regression - Githubissues

bflad / tfproviderlint

Terraform Provider Lint Tool

Mozilla Public License 2.0

135 stars 25 forks source link

v0.28.0 "// lintignore" regression #251

Closed armsnyder closed 2 years ago

armsnyder commented 2 years ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

tfproviderlint Version

$ tfproviderlint -version
v0.28.0

Affected Check(s) or Function(s)

Affects the lintignore comment pass.

Expected Behavior

Expected existing // lintignore: XXXXX // my description comments (with a leading space and description) to function correctly and ignore issues on the subsequent lint after upgrading from v0.27.1 to v0.28.0

Actual Behavior

// lintignore: XXXXX // my description comments no longer suppress issues.

armsnyder commented 2 years ago

I can take a look at this.

bflad commented 2 years ago

For what its worth, Go comment directives should not contain the space by convention: https://github.com/golang/go/issues/43776

However since the previous comment ignore logic was automatically stripping the spaces prior to v0.28.0, I guess we should still support the syntax.

armsnyder commented 2 years ago

Thanks for the context re: directives 👍

bflad commented 2 years ago

v0.28.1 has been released