Support to Node version 12

bfmatei / apollo-prometheus-exporter

Plugin for Apollo Server to export metrics in Prometheus format

MIT License

55 stars 29 forks source link

Closed rodrigomageste closed 3 years ago

rodrigomageste commented 3 years ago

Hey man, your lib is awesome.

I'm trying to use it in my project, but nullish coalescing operator (??) and optional chaining operator (? .) seems not work in Node 12.

I made some modifications in the code (basically I changed these operators) and now seems work. Do you intend to support Node 12?

tclass commented 3 years ago

I'm also interested in that, have the exact same problem

rodrigomageste commented 3 years ago

I can send a PR with my modifications if @bfmatei wants. Like I said, it's very simple, I just changed the operators (?? and ?.) mentioned above.

bfmatei commented 3 years ago

:tada: This issue has been resolved in version 1.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

bfmatei commented 3 years ago

Sorry for the long waiting. Unfortunately I had a medical condition that kept me away from personal projects lately.

Can you please test v1.2.0 and confirm it is working properly?

Thanks!

rodrigomageste commented 3 years ago

It worked perfectly, I already tested it here. Thanks a lot @bfmatei!

bfmatei commented 3 years ago

No worries!

Closing this now.

bfmatei commented 3 years ago

:tada: This issue has been resolved in version 1.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: