bfortuner / pytorch_tiramisu

FC-DenseNet in PyTorch for Semantic Segmentation
MIT License
306 stars 66 forks source link

A tiny mistake in tiramisu-pytorch.ipynb #2

Closed Khanimar closed 6 years ago

Khanimar commented 7 years ago

In update_viz_summary_plot fuction:

` def update_viz_summary_plot(self):

    trn_loss = self.loss_history['train'][-1]

    val_loss = self.loss_history['val'][-1]

    trn_err = self.error_history['train'][-1]    

    val_err = self.error_history['val'][-1]

    txt = ("""Epoch: %d

        Train - Loss: %.3f Err: %.3f

        Test - Loss: %.3f Err: %.3f""" % (self.epoch, 

        trn_loss, trn_err, tst_loss, tst_err))

    window = self.visdom_plots['summary']

    return viz.text(

        txt,

        win=window,

        env=self.name

    )

` there are no tst_loss and tst_err variables.

So I think they should be replaced by val_loss and val_err respectively, right?

raghavab1992 commented 7 years ago

Yes i had the same issue! Need to Replace it with val_loss and val_err.

bfortuner commented 6 years ago

Cleaned up the notebook and removed the visdom stuff for simplicity.