Closed kigster closed 6 years ago
Boxbot looks like a good idea. I've done that sort of by hand way too many times. Enough so that I added a bit of DSL magic to my sketch gem, but it was never very pretty. I'm interested in seeing what you come up with.
Thanks for putting so much effort into this, but I'm going to reject it is as-is. Feel free to make changes and push it again if you're still interested.
No worries, I’ll use my own fork. Tabs are big no no in ruby, and naming test files correctly helps IDEs to find them.
Since you prefer heavily non standard configuration, you are on your own.
Note that your gem breaks on CI right now due lack of mathn dependency declared in the gemspec. Thought you might want to at the very least fix that.
Note — this PR does not add or remove any functionality: it's a purely "fix this up" and bring this wonderful gem into 2018 by using correct formatting, newer rubies, and adding the missing dependency to the gemspec. I would love to be able to use this gem in my rewrite of the laser-cutter and may need to add some transformations such as rotations and shifting (unless they are already there), and I wanted to first submit a PR that, hopefully, should not be very controversial.
Note — also that the best way to see the real differences is to turn off white-space in
git diff -w ...
. Unfortunately, due to the squashed commit,git
was unable to recognize that the files were merely renamed, not changed.And btw, the new gem I am writing is boxbot.
Changes in the PR
mathn
gem to the gemspec to make the tests pass locally and on CI