search

bfoz / geometry

Geometric primitives for Ruby
https://rubygems.org/gems/geometry
BSD 2-Clause "Simplified" License
47 stars 18 forks source link

Remove mathn dependency #77

Closed netizer closed 5 years ago

netizer commented 6 years ago

As mathn is deprecated and as it overwrites basic math operations globally (which breaks applications written in ruby 5.1), I prepared this PR that removes mathn and relies on standard ruby methods.

The tests for this PR break for Ruby 2.0. Please advise, if I should fix the tests for this version of ruby, or it's better to remove the support for version 2.0 (which is pretty old)

a-fent commented 6 years ago

Polite bump :) - would it be possible to integrate this patch please? Ruby 2.5 is fairly widespread now and the mathn dependency creates an awkward global change.

bfoz commented 6 years ago

Thanks for the bump, and sorry for disappearing again.

I'm fine with dropping support for ruby 2.0. It looks like 2.1 and 2.2 are also EOL, so there's no need to test on those either. I'll push a commit to update the gemspec, etc.

Would you mind cleaning up the whitespace changes in the commit? I know the files have a lot of trailing whitespace garbage, but I prefer to keep the commits clean. Fixing whitespace on a line that's otherwise changed is fine though.

netizer commented 5 years ago

Ha, somehow I missed your message, sorry. I'll clean it it up in a sec.

netizer commented 5 years ago

@bfoz done. Please, let me know if I can do something else.

bfoz commented 5 years ago

@netizer Thanks for taking care of this.

BTW, I updated the Travis config and it looks like we're good on rubies 2.5 and 2.6 now

netizer commented 5 years ago

Awesome! Thanks for the merge :-)