bfrgoncalves / INNUENDO_REST_API

Frontend application and REST API for the INNUENDO Platform
GNU General Public License v3.0
5 stars 5 forks source link

Batch upload with metadata leading into corrupted entries #42

Closed jhalkilahti closed 7 years ago

jhalkilahti commented 7 years ago

Uploaded the fastq and metadata file. All analysis added to the files failed and one of the entries look like in the capture below. The real issue is in the metadata file but there should be a fail safe to prevent getting this far with a bad file.

capture

bfrgoncalves commented 7 years ago

Are the files named correctly on the batch file and still get the error or you have files from different samples in the batch file?

jhalkilahti commented 7 years ago

The metadata file is the messed up one you've seen before the EFSA demo. Something is wrong with the formatting but neither of us could figure out what. Demo strains.txt

bfrgoncalves commented 7 years ago

The problem that you are showing with the files with different names was due to the lack of a confirmation procedure to check if the file exists on the user files folder. Because of that the strain was being submitted with the first file existing on the user folder. The problem of the failed analysis was due to the Submitter on the batch file not being the same as the current logged user. This was raising some issues on job submission. Now there is a validation step to check if the submitter on the batch file matches the current user.

jhalkilahti commented 7 years ago

The check for Submitter on metadata and logged user is working but now the uploaded samples look like this: incorrect_order

jhalkilahti commented 7 years ago

Also selecting any sample (by using the tick box on the left) is impossible.

jhalkilahti commented 7 years ago

Reloading the view the issue is resolved on it's own.

bfrgoncalves commented 7 years ago

I will take a look

bfrgoncalves commented 7 years ago

It should be ok now. Had to change the way I was mapping the headers with the data on the columns.