a mess of changes about robustness and speed

bfritscher / carnac

A utility to give some insight into how you use your keyboard

http://carnackeys.com/

Microsoft Public License

695 stars 69 forks source link

a mess of changes about robustness and speed #3

Closed gdh1995 closed 7 years ago

gdh1995 commented 7 years ago

This PR includes 3 commit for different purposes:

the first one is for safer code
- in case that mousewatcher thread wants to join the main thread when the program is exiting.
- I once met the case and my mouse got stuck for seconds.
the second one is for speed:
- there're tons of mousemove events grabbed by mousewatcher,
- in this case it should not do works across threads, so that CPU utilization may be lower.
the third is a new settting item "AutoUpdate" (just for my personal opinion)
- I think one program should allow users to decide whether or not to auto-update itself
- Since this repo is bfritscher/carnac, so I set the default of AutoUpdate false.

gdh1995 commented 7 years ago

If the "AutoUpdate" is not a good practice, please let me know and I'll delete this commit from this PR.

bfritscher commented 7 years ago

Hi! thanks for all your commits. The mouse tracking was a first quick fix and learn the code base. It now seems that there is a better library https://github.com/gmamaladze/globalmousekeyhook to track also middle click, and mouse wheel and have access to the eventargs. This would allow to see if a ctrl key is pressed with the mouse and display it with the keys. So I plan to switch to this version.

gdh1995 commented 7 years ago

That's cool. Thanks for your work.

And what about adding an option to control "auto update"?

bfritscher commented 7 years ago

Hi I have done some cleanup added, new feature and the new mouse support. If you have time to give it a try and provide any feedback. Thanks https://github.com/bfritscher/carnac/releases/tag/v3-beta