search

bfrosik / data-quality

Other
5 stars 5 forks source link

added pvVerifier #6

Closed bfrosik closed 8 years ago

bfrosik commented 8 years ago

I will change it to this. There are a few more: qualityChecks -> qualitychecks, structureVerifier -> structureverifier, but how about basicHD5.json. I would leave it as is, since this is json file.

dgursoy commented 8 years ago

Just for the python modules. JSON can stay as is.

Does it make sense to have a module called verifier and put pvVerifier and structureVerifier in it?

bfrosik commented 8 years ago

That's a good point. The pvverifier verifies process variables, the structureverifier verifies the structure of a file (i.e. tags, dimentions, etc.), and the verifier is the real time application that calls the verifiers plus quality checks. I would leave the two (pvverifier and structureverifier) as is but rename verifier. How about dataintegrityvalidator? Please share your idea to remane the file, if this is too long.

dgursoy commented 8 years ago

Why rename verifier? I would keep verifier as is, since it's simpler.

bfrosik commented 8 years ago

then let's keep it.