bfwg / ngx-drag-scroll

A lightweight responsive Angular carousel library
https://ngx-drag-scroll.fanjin.io
MIT License
342 stars 95 forks source link

fix: update Angular to v14 and remove flex-layout as a dependency #296

Closed ViliMakinen closed 1 year ago

ViliMakinen commented 1 year ago

Updated to use Angular v14:

Projects using this library get peer dependency warnings when trying to update to Angular v14.

Projects using this library can now upgrade to Angular v14 without peer dependency warnings.

Yes, the package now requires users to use Angular v14.

Unit tests don't pass locally - I'm interested to see if they pass when run in the CI pipeline. (const scrollbarWidth = '15px' in the ngx-drag-scroll.component.spec.ts needs to be changed to '17px' to get tests to pass when run locally);

Schloesslin commented 1 year ago

Hi,

When this bug will be push ?

Thanks :)

ViliMakinen commented 1 year ago

@bfwg thanks for the heads up! The CI tests are failing due to Angular CLI requiring a Node version of 14.15 or 16.10 or higher. Currently the CI pipeline uses a Node version of 12.

I'll remove the Node version 12 from the node-version matrix in the ci.yml if that's alright!

bfwg commented 1 year ago

14.0.0-beta.2 is out with your change. Great work 🚀