Closed ViliMakinen closed 1 year ago
Hi,
When this bug will be push ?
Thanks :)
@bfwg thanks for the heads up! The CI tests are failing due to Angular CLI requiring a Node version of 14.15 or 16.10 or higher. Currently the CI pipeline uses a Node version of 12.
I'll remove the Node version 12 from the node-version matrix in the ci.yml
if that's alright!
14.0.0-beta.2 is out with your change. Great work 🚀
Please check if the PR fulfills these requirements
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] Unit tests are passing
ng test
[x] Lint tests are passing
ng lint
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Updated to use Angular v14:
Projects using this library get peer dependency warnings when trying to update to Angular v14.
Projects using this library can now upgrade to Angular v14 without peer dependency warnings.
Yes, the package now requires users to use Angular v14.
Unit tests don't pass locally - I'm interested to see if they pass when run in the CI pipeline. (
const scrollbarWidth = '15px'
in thengx-drag-scroll.component.spec.ts
needs to be changed to'17px'
to get tests to pass when run locally);