bgamari / ghc-pretty-errors

Design planning for prettier error messages from GHC
8 stars 1 forks source link

Annotated documents proposal #6

Closed alpmestan closed 4 years ago

alpmestan commented 4 years ago

@goldfirere @bgamari This is part 2 of the plan. Feedback welcome!

alpmestan commented 4 years ago

Yes, I should definitely mention #8089 somewhere, I forgot, thanks!

alpmestan commented 4 years ago

Updated the document to reflect your feedback.

alpmestan commented 4 years ago

@goldfirere I just pushed a new commit which hopefully addresses all your feedback. Let me know what you think about this update, when you get a chance. :-)

alpmestan commented 4 years ago

Thanks for the new round of feedback, I hopefully addressed all of it in the latest update.

alpmestan commented 4 years ago

@goldfirere Is this good to go for you?

goldfirere commented 4 years ago

Yes, go for it. I have not done another review, but it's better to start getting public feedback and to keep this process rolling forward. Thanks!

alpmestan commented 4 years ago

https://github.com/ghc-proposals/ghc-proposals/pull/307