search

bgamari / monoidal-containers

Maps using values' monoidal structure during merging
Other
42 stars 33 forks source link

Add instances of monoid-subclasses? #40

Open blamario opened 5 years ago

blamario commented 5 years ago

Since I fixed issue #24 of monoid-subclasses, the containers' Map and IntMap instances have become less useful. I considered adding instances for MonoidalMap in their place, but monoidal-containers has become a heavy dependency since its addition of aeson.

As an alternative, I wonder if you'd be open to a PR adding the monoid-subclasses as a dependency and the relevant instances? It would bring in only one transitive dependency, namely primes.

fumieval commented 3 years ago

-1 from me. monoid-subclasses seems to be a lot more progressive than monoidal-containers where its sole purpose is to provide a different definition of the Semigroup instance, so I think it should be the other way around.

I believe the plan is to switch to indexed-traversable, which reduces the dependency footprint a lot