search

bgamari / trac-to-remarkup

Moved to GitLab: https://gitlab.haskell.org/bgamari/trac-to-remarkup
https://gitlab.haskell.org
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

CC field is ignored #11

Closed mpickering closed 5 years ago

mpickering commented 5 years ago

See this empty comment: https://gitlab.staging.haskell.org/ghc/ghc/issues/8809#note_77602

It is Ben adding himself to the CC list. This list is important as it means people who are not receiving all the emails receive updates to specific tickets.

CC events should correspond to the subscription API call I believe -

https://docs.gitlab.com/ee/api/issues.html#subscribe-to-an-issue

CC removal by the unsubscribe endpoint

https://docs.gitlab.com/ee/api/issues.html#unsubscribe-from-an-issue

tdammers commented 5 years ago

One issue with this is that we need to block (or intercept) notifications during the import, otherwise gitlab will happily send them out as we continue importing status updates and such after adding a CC.

bgamari commented 5 years ago

One issue with this is that we need to block (or intercept) notifications during the import, otherwise gitlab will happily send them out as we continue importing status updates and such after adding a CC.

Yes, that is absolutely true. However, I believe this can be easily done in the GitLab configuration.

tdammers commented 5 years ago

Seems to work, although I don't see any notes being inserted by gitlab. Not sure if that's supposed to happen, but I doubt anyone links to those comments anyway.

tdammers commented 5 years ago

OK, so I verified that imported subscriptions reflect in the "notifications" slider when impersonating the subscriber. I take it that this means it works as intended, even if we're not seeing any additional UI cues.