search

bgamari / trac-to-remarkup

Moved to GitLab: https://gitlab.haskell.org/bgamari/trac-to-remarkup
https://gitlab.haskell.org
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Activitiy graph does not respect updated_at field #13

Open mpickering opened 5 years ago

mpickering commented 5 years ago

The activity graph for everyone reports the times the events occurred rather than the timestamps of the events.

https://gitlab.staging.haskell.org/trac-edsko

This is probably low priority and an upstream problem.

bgamari commented 5 years ago

I think the problem is actually worse than this: when a comment mentions another ticket the "mentioned by" comment producted on the mentioned ticket doesn't respect updated_by either. See the bottom of https://gitlab.staging.haskell.org/ghc/ghc/issues/11198#note_109457

bgamari commented 5 years ago

I believe the relevant bits of GitLab are in app/services/system_note_service.rb.

tdammers commented 5 years ago

Is this the same problem as #10, or a separate one?

bgamari commented 5 years ago

This was essentially the same problem as #10.

bgamari commented 5 years ago

While it seems to be a similar issue, it sadly wasn't fixed by the patch. That being said, I'm not sure it's worth spending time trying to fix this.

tdammers commented 5 years ago

Does the post-import fixup (the part that goes directly to the gitlab database) take care of this?

bgamari commented 5 years ago

No, it wasn't immediately obvious to me where the activity graph data comes from so I didn't bother to fix it in the post-import fixup. That being said, if it's obvious to someone else it wouldn't be hard to fix.