search

bgamari / trac-to-remarkup

Moved to GitLab: https://gitlab.haskell.org/bgamari/trac-to-remarkup
https://gitlab.haskell.org
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Comment description changes are uninformative #14

Closed mpickering closed 5 years ago

mpickering commented 5 years ago

For example:

https://gitlab.staging.haskell.org/ghc/ghc/issues/15736#note_134379

tdammers commented 5 years ago

That is true. I mainly made it this way to still retain some sort of indication that the description had been changed, but without littering the history with the full description texts before and after.

We could either turn them into full-blown description diffs, but that would be a lot of work for questionable gain, or we could discard the change information, and just update the description in place, which would mean we lose that information (unless gitlab tracks versions of descriptions - but I haven't found anything to this extend yet).

mpickering commented 5 years ago

There is a note that is generated when the description is changed but it doesn't seem that you can easily see the diff of how the description changed?

https://gitlab.staging.haskell.org/ghc/ghc/issues/15945#note_142566

mpickering commented 5 years ago

Upstream issue is: https://gitlab.com/gitlab-org/gitlab-ce/issues/15597

tdammers commented 5 years ago

Hmm, so gitlab does retain the information, but doesn't show it in the UI? If that is the case, then I'd vote we just import the new description, don't generate our own note, and hope for the gitlab folks to expose this information in the (near) future. Or maybe even patch gitlab ourselves.

On Thu, Dec 6, 2018, 13:03 Matthew Pickering <notifications@github.com wrote:

Upstream issue is: https://gitlab.com/gitlab-org/gitlab-ce/issues/15597

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bgamari/trac-to-remarkup/issues/14#issuecomment-444849112, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXjx8OjhGcip6yqmzN1QuGdhuL4vS6zks5u2QeBgaJpZM4Y-3rO .

mpickering commented 5 years ago

How I read it is that they currently don't store the diffs but they plan to implement it in the first quarter of 2019.

Apparently it will take quite a bit of effort to implement - "I think. I'd say that's definitely someone's main priority for the month."

tdammers commented 5 years ago

Oh, hmm, so the information isn't retained yet. Pity.

I could probably slap a standard diff library in there and generate diffs myself, but I wonder if it'd be worth it.

mpickering commented 5 years ago

I personally don't think the edit history of a comment is too important to retain.

tdammers commented 5 years ago

Alright, so we're not doing this. I'll just remove the "description" field from the trac metadata tables.