search

bgamari / trac-to-remarkup

Moved to GitLab: https://gitlab.haskell.org/bgamari/trac-to-remarkup
https://gitlab.haskell.org
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Fix #4, #5 #16

Closed tdammers closed 5 years ago

tdammers commented 5 years ago

Fixes #4

tdammers commented 5 years ago

This still posts an empty comment?

It shouldn't - b107cf16be6916d7980a488b522110423afc46e0 adds a check that skips note creation when there is nothing to put in the note. In order for this to work, b7538e2f608a0a00e752456b5d280a9cb60bb753 is also required, otherwise the body always contains at least the trac comment number.

It will still create notes in cases when a "Trac metadata" popout table is generated, as that becomes part of the note body. Without 9d9ff7b0776c159e3793d6382c3a4ef59fa94b4b, this table will be populated for status, milestone, and keyword changes; if there is other metadata that we would want to skip, by all means let me know.