Corp tag for Profile name breaks [quote]'s

[GoogleCodeExporter]

TEA Version?
1.2.0.131
SMF Version?
2.0 gold

What steps will reproduce the problem?
1. set the corp ticker setting as "part of name"
2. try quoting someone's post on the forum.
3.

What is the expected output? What do you see instead?
It should just quote the post, as expected, but instead it quotes the person's 
post and include's the authors additions as part of the post, as the []'s break 
the quote bbcode.

Please provide any additional information below.

I have done one of my famous demi hax to change it to {}'s. Not sure if that's 
what you would use, but thats how ive got round the "bug" so far, even though 
its not really a bug... you know what i mean :P.

Changed line 2301 and 2342 to 
$name = '{'.$char[3].'} '.$name;

Original issue reported on code.google.com by DTHI.Dem...@gmail.com on 19 Jul 2011 at 2:27

[GoogleCodeExporter]

changed 2301 and 2342 of TEA.php to...
$name = ''.$char[3].' - '.$name;

Looks a bit better then :)

Original comment by sc...@pieh0.co.uk on 24 Jul 2011 at 8:04

[GoogleCodeExporter]

Can we get this committed please, every time i update i have to keep changing 
the source so my alliance mates dont cry about quote's being broken :P.

Also found out my hack broke the part where you can select your account name in 
"Account Settings", as its expecting the old format, but is getting the new one.

Heres a diff so you can put it in quickly.

906c906
<                                                               $char[0] = 
"".$char[1]." - ".$char[0];
---
>                                                               $char[0] = 
"[".$char[1]."] ".$char[0];
2381c2381
<                                               $name = ''.$char[3].' - '.$name;
---
>                                               $name = '['.$char[3].'] '.$name;
2422c2422
<                                               $name = ''.$char[3].' - '.$name;
---
>                                               $name = '['.$char[3].'] '.$name;
3010c3010
<                                       $echo[] = ''.$char[1].' - '.$char[0].' 
(<green>'.$char[2].'</green>'.$char[3].')';
---
>                                       $echo[] = '['.$char[1].'] '.$char[0].' 
(<green>'.$char[2].'</green>'.$char[3].')';

Original comment by sc...@pieh0.co.uk on 28 Jul 2011 at 5:06

[GoogleCodeExporter]

Also, that diff is for the current version of TEA (rev143).

Original comment by sc...@pieh0.co.uk on 28 Jul 2011 at 5:13

[GoogleCodeExporter]

yer i planned to fix, but my plan was for something better fix, like giving you 
a setting for the format similar to wat i did under TS area
going to start on it now

Original comment by tema...@googlemail.com on 28 Jul 2011 at 5:22

• Changed state: Accepted

[GoogleCodeExporter]

Ah cool, that would be much better.

Thanks again! :P

Original comment by sc...@pieh0.co.uk on 28 Jul 2011 at 5:56

[GoogleCodeExporter]

Original comment by tema...@googlemail.com on 28 Jul 2011 at 10:02

• Changed state: Fixed-SVN

[GoogleCodeExporter]

Just upgraded, that is waayyyy better.

Thanks for the quick work and sorry if i sounded pushy :)

demi

Original comment by sc...@pieh0.co.uk on 29 Jul 2011 at 2:59

[GoogleCodeExporter]

its understandable especially if u like to keep updating with latest dev
which i dont mind as its easier to find bugs before release with others using
and i bought this would of got fixed for god know how long if u didnt report
i mean this bug has pretty much been here since the beginning 

Original comment by tema...@googlemail.com on 29 Jul 2011 at 3:01

[GoogleCodeExporter]

Yea, its more of a bug with smf than with TEA, seeing as they didnt bother to 
sort out what the quote function should do if the username has brackets in the 
display name :P.

Original comment by sc...@pieh0.co.uk on 29 Jul 2011 at 3:08

[GoogleCodeExporter]

yer i was considering looking into that and fixing it my self and passing it on 
too em :p

and ofc the fix would be part of tea till they added

and i may do so 1 day
esp since my corp is used to [] and even use that in TS

Original comment by tema...@googlemail.com on 29 Jul 2011 at 3:10

[GoogleCodeExporter]

Original comment by tema...@googlemail.com on 14 Aug 2011 at 3:07

• Changed state: Fixed