bgantzler / ember-mirage

Aids in setting up mirage for ember testing
MIT License
4 stars 5 forks source link

Pass additional options into the makeServer function #11

Closed cah-brian-gantzler closed 1 year ago

cah-brian-gantzler commented 1 year ago

I use husky to setup an auto run of prettier when a commit happens on all my work repos. So always forget to run it on open source repos that require it manually. Mind if I add Husky and run prettier and lint on commit?

NullVoxPopuli commented 1 year ago

Mind if I add Husky and run prettier and lint on commit?

as long as it's optional / doesn't hook in to prepare, that's fine. The thing with husky is it requires you to have successfully installed your dependencies before it'll work -- which, when it blocks commits, can be really annoying for contributors who just want to change documentation (often the most neglected, and where the most help is needed)

cah-brian-gantzler commented 1 year ago

Husky hooks into git commit, so I think would be same thing. :( I always forget to run prettier lint manually and then test CI fails because it wasnt run. sigh