search

bgantzler / ember-mirage

Aids in setting up mirage for ember testing
MIT License
4 stars 5 forks source link

Prepare Release #34

Closed github-actions[bot] closed 3 months ago

github-actions[bot] commented 7 months ago

This PR is a preview of the release that release-plan has prepared. To release you should just merge this PR 👍

Release (2024-07-17)

ember-mirage 0.3.1 (patch)

:bug: Bug Fix

:memo: Documentation

:house: Internal

Committers: 4

cah-brian-gantzler commented 7 months ago

Sorry @mansona , not use to labeling PRs. I updated after the fact. I think I read it will prepare a new release if I do that.

EDIT: Looks like it might have failed to recreate the release plan once I did that. https://github.com/bgantzler/ember-mirage/actions/runs/8193989829/job/22409005312

mansona commented 7 months ago

yea unfortunately this is something that GitHub is limiting us and there is nothing we can do to fix it (right now). Essentially the "label it after you merge" workflow only works if the PR is coming from a branch that is on the origin repo, it doesn't work if the PR comes from a fork 😞

The way to unblock this is to run the last Release Plan Review job that ran on main: https://github.com/bgantzler/ember-mirage/actions/workflows/plan-release.yml?query=branch%3Amain

cah-brian-gantzler commented 7 months ago

Found the correct job that needed to be re-run. Thanks. Will try to remember proper labeling in the future.

mansona commented 7 months ago

oh I just noticed something, that's not giving you a new version at the top of the release 🤔 it looks like by default documentation labels don't count as patches.

Unless you want to update docs on npm I would recommend not merging this until there is a PR that makes at least a patch on the package

cah-brian-gantzler commented 7 months ago

Gotcha

mansona commented 7 months ago

now you can see it has the line ember-mirage 0.3.1 (patch) which means that's the version it's going to release 👍

cah-brian-gantzler commented 7 months ago

The other change I wanted to make to the docs was not a correct but documenting a feature. I would like to experiment a little more on how its working before I document that, so it can wait.

Should I merge this? Or we expecting a couple more minor tweaks we would like to wait on?

mansona commented 3 months ago

@cah-brian-gantzler you can merge this now if you're happy with the example in the description 👍 You should feel empowered to merge these releases as much as you like, release-plan is designed to remove friction to help people release as often as they like 🎉