bgarrels / textpattern

Automatically exported from code.google.com/p/textpattern
0 stars 0 forks source link

Apostrophes should not be converted to hyphens for URLs #102

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

Using an apostrophe in a page title, it is converted to a hyphen when 
generating the URL (if you don't specific your own URL).

What version of the product are you using? On what operating system?

v4.3.0

Please provide any additional information below.

When an article title has apostrophes in it, Textpattern currently turns that 
into a hyphen when making up a URL. Don’t you think it would be better to 
simply remove that character in URLs instead?

For example, a title of:

It's my article

Currently is converted to a URL of:

mysite.com/it-s-my-article

When it could be:

mysite.com/its-my-article

Since URLs are an important part of SEO these days, I think it should be 
changed. Also, some plugins have minor issues with it in the current state 
(such as arc_twitter).

Original issue reported on code.google.com by flaming....@mac.com on 22 Feb 2011 at 11:58

GoogleCodeExporter commented 9 years ago
Unless it's a regression, we'd rather not fix problems with plugins by adapting 
in core.

Original comment by r.wetzlmayr on 22 Feb 2011 at 12:35

GoogleCodeExporter commented 9 years ago
Just for the record, the issue is not with arc_twitter (as far as I am aware), 
but with core. For the above example, on the ping callback the article url 
formed by Textpattern is the latter, whereas the actual url used by TXP is the 
former. This is also affecting TXP's 'View' link after the initial save.

I've tried to develop arc_twitter to rely on TXP's core methods, but in this 
case core doesn't seem to be reliable enough.

Original comment by andy1...@gmail.com on 22 Feb 2011 at 1:52

GoogleCodeExporter commented 9 years ago
Closing this issue as WontFix for three reasons:

# The interpretation of apostrophes depends on culture. While it may be a "dead 
character" in English it might as well be a relevant punctuation character in 
other languages.
# URL titles can be set by plugins through the 'sanitize_for_url' callback if 
the default implementation does not fit your specific requirements. 
# While we strive to make Textpattern as SEO-friendly as possible out of the 
box, we cannot chase all SEO parameters du jour without some solid evidence.

Re: comment 2#: I cannot reproduce any inconsistencies in the generated 
$url_title in Textpattern 4.4.1. Please reopen another issue if you still 
experience difficulties.

Original comment by r.wetzlmayr on 10 Jan 2012 at 6:48