bgarrels / textpattern

Automatically exported from code.google.com/p/textpattern
0 stars 0 forks source link

Call to undefined function privs() #213

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
<br />
<b>Fatal error</b>:  Call to undefined function privs() in 
<b>/var/www/localhost/htdocs/textpattern/lib/txplib_head.php</b> on line 
<b>133</b><br

Original issue reported on code.google.com by Alexande...@gmail.com on 23 Jun 2012 at 8:59

GoogleCodeExporter commented 9 years ago
More info please. Which version of Textpattern, under what circumstances do you 
see the error, etc? It could be a plugin.

Original comment by stefdawson on 24 Jun 2012 at 11:57

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
current version, r3832.
installation only with plugin bot_privs.
unckeck permission to admin sub-tabs.
press admin tab in menu - see blank page, in code see this strings.

Original comment by Alexande...@gmail.com on 24 Jun 2012 at 3:41

GoogleCodeExporter commented 9 years ago
OK, I know why it's doing it. If you shut off the admin tab entirely, 
txplib_head is still trying to populate the multi-edit dropdown with a call to 
the privs() function that is contained in include\txp_admin.php.

Under the core, it's never be possible to switch off the admin tab (primarily 
because of the password change functionality) but plugins like bot_privs and 
smd_user_manager permit it and should be protected from this kind of (lack of) 
encapsulation error.

Simplest solution would be to move the privs() function out of txp_admin.php to 
one of the library files. Alternatively, Gocom is working on refactorisation of 
the multi-edit toolset which might bring with it a better workflow and less 
reliance on functions that are defined elsewhere.

So we'll sit on this for a few days and see what happens with the multi-edit 
code changes; then resolve it either way next week.

Original comment by stefdawson on 26 Jun 2012 at 9:16

GoogleCodeExporter commented 9 years ago
Fixed in r3859.

Original comment by stefdawson on 28 Jun 2012 at 10:10