bgaze / bootstrap-form

Bootstrap 4 forms builder for Laravel 5.8+
https://packages.bgaze.fr/bootstrap-form
MIT License
53 stars 5 forks source link

Support for Bootstrap 5 #17

Open ronvdberkmortel opened 3 years ago

ronvdberkmortel commented 3 years ago

Hello,

Since the third Alpha version of Bootstrap 5 will be out soon, it would be great if support could be added to this package. In my opinion, this package offers the best combination with regards to forms in Laravel and Bootstrap. I am sadly not too familiar with the inner workings of the package, else I would have created a proposal.

The changelog is not that huge regarding forms (https://v5.getbootstrap.com/docs/5.0/migration/):

I am not sure if it's best to support two versions of the package or to add a config variable to switch between v4 and v5. Since the forms are rather similar, it might be easiest to add a config variable.

bgaze commented 3 years ago

Dear @ronvdberkmortel

Thanks a lot for your message.

I definitely plan to add support for Bootstrap 5 to this package.

As most of changes are on the CSS side, it must not be too difficult.
For what I've seen, there are three main points to update in the package for a bs5 version:

As I want the package to stick as much as possible to bootstrap, I think that I'll build two versions: v1.x.x for BS4 and v2.x.x for BS5.
This way I should be able to keep a clean code for each BS version.

I'll try to dive into this soon and I'll keep you in touch as soon as a release is made.

ronvdberkmortel commented 3 years ago

It appears that Bootstrap 5 Beta 1 has been released in the meantime: https://blog.getbootstrap.com/2020/12/07/bootstrap-5-beta-1/

There seem to be no major changes to the forms. Also, because it is in beta, I assume the current form classes will be the same as in the final release.

ronvdberkmortel commented 3 years ago

Not trying to pressure you of course, but have you had a chance to work on Bootstrap 5 support? The Bootstrap website has switched to Bootstrap 5 as its default version and we are currently on v5.0.0-beta3, which appears to be close to identical to the final release version. :)