Seatbelt improvements/consistency

bgd-labs / aave-governance-v3-interface

Interface to interact with the Aave Governance v3 smart contracts

https://vote.onaave.com/

Other

13 stars 2 forks source link

Seatbelt improvements/consistency #81

Closed sakulstra closed 7 months ago

sakulstra commented 7 months ago

Follow up to: https://github.com/bgd-labs/aave-governance-v3-interface/issues/77

On the reports screen it would be nice to have a link to the source of the report (the seatbelt repo) as sometimes the report is huge & there are subreports i want to check.
While on the "create proposal" view the reports are shown on the ui, on the other pages it's _blank links. I think would be good consistently inline the report.

Argeare5 commented 7 months ago

@sakulstra if I look from the logic side and considering this While on the "create proposal" view the reports are shown on the ui, on the other pages it's _blank links. I think would be good consistently inline the report. , maybe then it’s better to just make a link everywhere? And not create a modal window in our UI?

sakulstra commented 7 months ago

@Argeare5 I don't have a to strong opinion. I think the inlining is kinda nice at it feels quicker then opening another page for each report (on multi report proposals). The time saved though is minimal, so idk. Both is fine with me.

cc: @eboadom