search

bgd-labs / aave-proposals-v3

MIT License
17 stars 18 forks source link

stablecoin harmonization - review #244

Closed Rozengarden closed 3 months ago

Rozengarden commented 3 months ago

my test are failling during the first call to vm.serializeJson(reserves, {}) with error "Invalid Data"

github-actions[bot] commented 3 months ago

Foundry report

forge 0.2.0 (e5318c3 2024-03-21T00:19:03.663363464Z)
Build log ```shell Compiling 417 files with 0.8.19 Solc 0.8.19 finished in 282.45s Compiler run successful with warnings: Warning (3628): This contract has a payable fallback function, but no receive ether function. Consider adding a receive ether function. --> src/20240218_AaveV1Ethereum_AaveV1DeprecationPhase2/AaveV1Ethereum_AaveV1Deprecation_20240218.t.sol:86:1: | 86 | contract AaveV1Ethereum_AaveV1Deprecation_20240218_Test is ProtocolV2TestBase { | ^ (Relevant source part starts here and spans across multiple lines). Note: The payable fallback function is defined here. --> src/20240218_AaveV1Ethereum_AaveV1DeprecationPhase2/AaveV1Ethereum_AaveV1Deprecation_20240218.t.sol:232:3: | 232 | fallback() external payable {} | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Warning (9302): Return value of low-level calls not used. --> src/20231229_Multi_TreasuryManagementGSMFundingRWAStrategyPreparationsPart1/AaveV2Ethereum_TreasuryManagementGSMFundingRWAStrategyPreparationsPart1_20231229.sol:47:5: | 47 | SAFE.call{value: address(this).balance}(''); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning. --> lib/aave-helpers/src/GovV3Helpers.sol:869:5: | 869 | address votingPortal | ^^^^^^^^^^^^^^^^^^^^ Warning (2018): Function state mutability can be restricted to pure --> src/20240104_Multi_Patch/Patch_20240104.s.sol:32:3: | 32 | function _getPayload() internal override returns (bytes memory) { | ^ (Relevant source part starts here and spans across multiple lines). Warning (2018): Function state mutability can be restricted to pure --> src/20240104_Multi_Patch/Patch_20240104.s.sol:43:3: | 43 | function _getPayload() internal override returns (bytes memory) { | ^ (Relevant source part starts here and spans across multiple lines). Warning (2018): Function state mutability can be restricted to pure --> src/20240104_Multi_Patch/Patch_20240104.s.sol:54:3: | 54 | function _getPayload() internal override returns (bytes memory) { | ^ (Relevant source part starts here and spans across multiple lines). Warning (2018): Function state mutability can be restricted to pure --> src/20240104_Multi_Patch/Patch_20240104.s.sol:65:3: | 65 | function _getPayload() internal override returns (bytes memory) { | ^ (Relevant source part starts here and spans across multiple lines). Warning (2018): Function state mutability can be restricted to pure --> src/20240104_Multi_Patch/Patch_20240104.s.sol:76:3: | 76 | function _getPayload() internal override returns (bytes memory) { | ^ (Relevant source part starts here and spans across multiple lines). Warning (2018): Function state mutability can be restricted to pure --> src/20240104_Multi_Patch/Patch_20240104.s.sol:87:3: | 87 | function _getPayload() internal override returns (bytes memory) { | ^ (Relevant source part starts here and spans across multiple lines). Warning (2018): Function state mutability can be restricted to pure --> src/20240104_Multi_Patch/Patch_20240104.s.sol:98:3: | 98 | function _getPayload() internal override returns (bytes memory) { | ^ (Relevant source part starts here and spans across multiple lines). Warning (2018): Function state mutability can be restricted to pure --> src/20240218_AaveV1Ethereum_AaveV1DeprecationPhase2/AaveV1Ethereum_AaveV1Deprecation_20240218.t.sol:207:3: | 207 | function _getUsers() internal returns (V1User[] memory) { | ^ (Relevant source part starts here and spans across multiple lines). Warning (2018): Function state mutability can be restricted to pure --> src/20240308_AaveV3Ethereum_GHOBorrowRateIncrease/GhoInterestRateStrategy.sol:67:3: | 67 | function getBaseVariableBorrowRate() external view override returns (uint256) { | ^ (Relevant source part starts here and spans across multiple lines). Warning (2018): Function state mutability can be restricted to pure --> src/20240308_AaveV3Ethereum_GHOBorrowRateIncrease/GhoInterestRateStrategy.sol:72:3: | 72 | function getMaxVariableBorrowRate() external view override returns (uint256) { | ^ (Relevant source part starts here and spans across multiple lines). Warning (2018): Function state mutability can be restricted to pure --> src/20240308_AaveV3Ethereum_GHOBorrowRateIncrease/GhoInterestRateStrategy.sol:77:3: | 77 | function calculateInterestRates( | ^ (Relevant source part starts here and spans across multiple lines). | Contract | Size (kB) | Margin (kB) | |----------------------------------------------------------------------------------------------------------|-----------|-------------| | AaveGovernanceV2 | 0.045 | 24.531 | | AaveSafetyModule | 0.045 | 24.531 | | AaveSwapper | 5.572 | 19.004 | | AaveV1Ethereum_AaveV1Deprecation_20240218 | 0.297 | 24.279 | | AaveV2Avalanche | 0.045 | 24.531 | | AaveV2AvalancheAssets | 0.045 | 24.531 | | AaveV2Avalanche_ChaosLabsRiskParameterUpdatesWBTCEOnV2AndV3Avalanche_20231221 | 0.336 | 24.24 | | AaveV2Avalanche_StablecoinIRCurvesUpdates_20231221 | 1.858 | 22.718 | | AaveV2Ethereum | 0.045 | 24.531 | | AaveV2EthereumAMM | 0.045 | 24.531 | | AaveV2EthereumAMMAssets | 0.045 | 24.531 | | AaveV2EthereumAMM_ARFCDeprecateAaveV2AMMMarketStep2_20240205 | 2.894 | 21.682 | | AaveV2EthereumAssets | 0.045 | 24.531 | | AaveV2Ethereum_AMPLInterestRateUpdatesOnV2Ethereum_20240121 | 1.602 | 22.974 | | AaveV2Ethereum_ChaosLabsV2EthereumLTReductions_20240201 | 0.926 | 23.65 | | AaveV2Ethereum_EthereumV2ReserveFactorAdjustment_20240304 | 4.904 | 19.672 | | AaveV2Ethereum_MigrationOfRemainingGovV2Permissions_20240130 | 0.977 | 23.599 | | AaveV2Ethereum_MigrationOfRemainingGovV2Permissions_Part2_20240130 | 1.446 | 23.13 | | AaveV2Ethereum_StablecoinIRCurvesUpdates_20231221 | 2.839 | 21.737 | | AaveV2Ethereum_TreasuryManagementGSMFundingRWAStrategyPreparationsPart1_20231229 | 3.415 | 21.161 | | AaveV2Ethereum_V2DeprecationPlan20240102_20240103 | 0.927 | 23.649 | | AaveV2Polygon | 0.045 | 24.531 | | AaveV2PolygonAssets | 0.045 | 24.531 | | AaveV2Polygon_ReserveFactorUpdatesFebruary152024_20240208 | 0.831 | 23.745 | | AaveV2Polygon_ReserveFactorUpdatesFebruary292024_20240229 | 0.683 | 23.893 | | AaveV2Polygon_ReserveFactorUpdatesJan152024_20240108 | 1.134 | 23.442 | | AaveV2Polygon_ReserveFactorUpdatesJan312024_20240125 | 0.831 | 23.745 | | AaveV2Polygon_ReserveFactorUpdates_20240102 | 0.995 | 23.581 | | AaveV2Polygon_ReserveFactorUpdates_20240313 | 0.535 | 24.041 | | AaveV2Polygon_StablecoinIRCurvesUpdates_20231221 | 1.858 | 22.718 | | AaveV3Arbitrum | 0.045 | 24.531 | | AaveV3ArbitrumAssets | 0.045 | 24.531 | | AaveV3ArbitrumEModes | 0.045 | 24.531 | | AaveV3Arbitrum_AaveProtocolEmbassy_20240220 | 0.435 | 24.141 | | AaveV3Arbitrum_AddFlashborrowers_20240306 | 0.25 | 24.326 | | AaveV3Arbitrum_AssignEmissionAdminEthereumArbitrumAndOptimism_20240229 | 0.323 | 24.253 | | AaveV3Arbitrum_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115 | 3.362 | 21.214 | | AaveV3Arbitrum_Patch_20240104 | 0.479 | 24.097 | | AaveV3Arbitrum_SetLiquidityObservationLabsAsEmissionManagerForWstETHOnV3Markets_20240206 | 0.212 | 24.364 | | AaveV3Arbitrum_StablecoinHarmonization_20240312 | 4.469 | 20.107 | | AaveV3Arbitrum_StablecoinIRCurvesUpdates_20231221 | 4.878 | 19.698 | | AaveV3Arbitrum_UpdateStETHAndWETHRiskParamsOnAaveV3EthereumOptimismAndArbitrum_20240121 | 3.892 | 20.684 | | AaveV3Arbitrum_UpdateWETHIROnV3ArbitrumAndOptimism_20240216 | 3.622 | 20.954 | | AaveV3Avalanche | 0.045 | 24.531 | | AaveV3AvalancheAssets | 0.045 | 24.531 | | AaveV3AvalancheEModes | 0.045 | 24.531 | | AaveV3Avalanche_ChaosLabsRiskParameterUpdatesWBTCEOnV2AndV3Avalanche_20231221 | 3.513 | 21.063 | | AaveV3Avalanche_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115 | 3.377 | 21.199 | | AaveV3Avalanche_Patch_20240104 | 0.479 | 24.097 | | AaveV3Avalanche_StablecoinHarmonization_20240312 | 3.983 | 20.593 | | AaveV3Avalanche_StablecoinIRCurvesUpdates_20231221 | 4.628 | 19.948 | | AaveV3BNB | 0.045 | 24.531 | | AaveV3BNBAssets | 0.045 | 24.531 | | AaveV3BNBEModes | 0.045 | 24.531 | | AaveV3BNB_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115 | 3.38 | 21.196 | | AaveV3BNB_OnboardFdUSDToAaveV3OnBSC_20240201 | 5.014 | 19.562 | | AaveV3BNB_SetAaveChanInitiativeAsEmissionManagerForFdUSDOnBNBChainAaveV3_20240208 | 0.212 | 24.364 | | AaveV3Base | 0.045 | 24.531 | | AaveV3BaseAssets | 0.045 | 24.531 | | AaveV3BaseEModes | 0.045 | 24.531 | | AaveV3Base_Patch_20240104 | 0.479 | 24.097 | | AaveV3Base_SetLiquidityObservationLabsAsEmissionManagerForWstETHOnV3Markets_20240206 | 0.212 | 24.364 | | AaveV3Base_StablecoinIRCurvesUpdates_20231221 | 3.618 | 20.958 | | AaveV3Ethereum | 0.045 | 24.531 | | AaveV3EthereumAssets | 0.045 | 24.531 | | AaveV3EthereumEModes | 0.045 | 24.531 | | AaveV3Ethereum_AaveLiquidityCommiteeFunding_20240306 | 1.964 | 22.612 | | AaveV3Ethereum_ActivationOfACPrimeFoundation_20240308 | 0.502 | 24.074 | | AaveV3Ethereum_AddFlashborrowers_20240306 | 1.223 | 23.353 | | AaveV3Ethereum_AddPYUSDToAaveV3EthereumMarket_20240125 | 4.993 | 19.583 | | AaveV3Ethereum_AmendSafetyModuleEmissions_20240229 | 2.399 | 22.177 | | AaveV3Ethereum_AssignEmissionAdminEthereumArbitrumAndOptimism_20240229 | 0.967 | 23.609 | | AaveV3Ethereum_ChaosLabsRiskParameterUpdatesIncreaseDebtCeilingForSNXAndMKROnV3Ethereum01312024_20240211 | 3.533 | 21.043 | | AaveV3Ethereum_CutGauntletServiceProviderStream_20240227 | 0.479 | 24.097 | | AaveV3Ethereum_FundingUpdate_20240224 | 10.54 | 14.036 | | AaveV3Ethereum_GHOBorrowRateIncrease20240229_20240229 | 0.285 | 24.291 | | AaveV3Ethereum_GHOBorrowRateIncrease_20240308 | 0.233 | 24.343 | | AaveV3Ethereum_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115 | 3.376 | 21.2 | | AaveV3Ethereum_MeritApprovals_20240306 | 0.534 | 24.042 | | AaveV3Ethereum_OrbitProgram_20240220 | 2.308 | 22.268 | | AaveV3Ethereum_Patch_20240104 | 0.479 | 24.097 | | AaveV3Ethereum_RegisterADIScrollAdapter_20240122 | 0.63 | 23.946 | | AaveV3Ethereum_RequestForBountyPayoutJanuary2024_20240125 | 0.781 | 23.795 | | AaveV3Ethereum_RetroactiveBugBountyPreImmunefi_20240205 | 0.782 | 23.794 | | AaveV3Ethereum_SecurityBudgetRequestDecember2023_20240206 | 0.514 | 24.062 | | AaveV3Ethereum_SetLiquidityObservationLabsAsEmissionManagerForWstETHOnV3Markets_20240206 | 0.212 | 24.364 | | AaveV3Ethereum_StableRateBugBounty_20240207 | 0.768 | 23.808 | | AaveV3Ethereum_StablecoinHarmonization_20240312 | 5.299 | 19.277 | | AaveV3Ethereum_StablecoinIRCurvesUpdates_20231221 | 4.627 | 19.949 | | AaveV3Ethereum_StkGHOActivation_20240119 | 1.115 | 23.461 | | AaveV3Ethereum_TreasuryManagementGSMFundingRWAStrategyPreparationsPart2_20240209 | 3.098 | 21.478 | | AaveV3Ethereum_UpdateStETHAndWETHRiskParamsOnAaveV3EthereumOptimismAndArbitrum_20240121 | 3.905 | 20.671 | | AaveV3Fantom | 0.045 | 24.531 | | AaveV3FantomAssets | 0.045 | 24.531 | | AaveV3FantomEModes | 0.045 | 24.531 | | AaveV3GenericPatch_20240104 | 0.479 | 24.097 | | AaveV3Gnosis | 0.045 | 24.531 | | AaveV3GnosisAssets | 0.045 | 24.531 | | AaveV3GnosisEModes | 0.045 | 24.531 | | AaveV3Gnosis_Patch_20240104 | 0.479 | 24.097 | | AaveV3Gnosis_StablecoinHarmonization_20240312 | 3.571 | 21.005 | | AaveV3Gnosis_StablecoinIRCurvesUpdates_20231221 | 3.87 | 20.706 | | AaveV3Harmony | 0.045 | 24.531 | | AaveV3HarmonyAssets | 0.045 | 24.531 | | AaveV3HarmonyEModes | 0.045 | 24.531 | | AaveV3Metis | 0.045 | 24.531 | | AaveV3MetisAssets | 0.045 | 24.531 | | AaveV3MetisEModes | 0.045 | 24.531 | | AaveV3Metis_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115 | 3.37 | 21.206 | | AaveV3Metis_StablecoinHarmonization_20240312 | 3.397 | 21.179 | | AaveV3Metis_StablecoinIRCurvesUpdates_20231221 | 3.869 | 20.707 | | AaveV3Optimism | 0.045 | 24.531 | | AaveV3OptimismAssets | 0.045 | 24.531 | | AaveV3OptimismEModes | 0.045 | 24.531 | | AaveV3Optimism_AddFlashborrowers_20240306 | 0.25 | 24.326 | | AaveV3Optimism_AssignEmissionAdminEthereumArbitrumAndOptimism_20240229 | 0.31 | 24.266 | | AaveV3Optimism_GauntletRecommendationForMAIMIMATICDeprecationPhase2_20240122 | 3.375 | 21.201 | | AaveV3Optimism_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115 | 3.362 | 21.214 | | AaveV3Optimism_Patch_20240104 | 0.479 | 24.097 | | AaveV3Optimism_SetLiquidityObservationLabsAsEmissionManagerForWstETHOnV3Markets_20240206 | 0.212 | 24.364 | | AaveV3Optimism_StablecoinHarmonization_20240312 | 3.749 | 20.827 | | AaveV3Optimism_StablecoinIRCurvesUpdates_20231221 | 4.878 | 19.698 | | AaveV3Optimism_UpdateStETHAndWETHRiskParamsOnAaveV3EthereumOptimismAndArbitrum_20240121 | 3.892 | 20.684 | | AaveV3Optimism_UpdateWETHIROnV3ArbitrumAndOptimism_20240216 | 3.609 | 20.967 | | AaveV3Polygon | 0.045 | 24.531 | | AaveV3PolygonAssets | 0.045 | 24.531 | | AaveV3PolygonEModes | 0.045 | 24.531 | | AaveV3Polygon_FreezeAndSetLTVTo0ForDPIBALCRVAndSUSHIOnAaveV3Polygon20240119_20240130 | 4.355 | 20.221 | | AaveV3Polygon_FundingUpdate_20240224 | 2.902 | 21.674 | | AaveV3Polygon_HarmonizeUSDTRiskParametersOnAaveV3Markets_20240115 | 3.361 | 21.215 | | AaveV3Polygon_MaticXSupplyCapIncreaseInPolygonV3_20240206 | 3.294 | 21.282 | | AaveV3Polygon_Patch_20240104 | 0.479 | 24.097 | | AaveV3Polygon_SetLiquidityObservationLabsAsEmissionManagerForWstETHOnV3Markets_20240206 | 0.212 | 24.364 | | AaveV3Polygon_StablecoinHarmonization_20240312 | 3.975 | 20.601 | | AaveV3Polygon_StablecoinIRCurvesUpdates_20231221 | 4.375 | 20.201 | | AaveV3Polygon_TreasuryManagementGSMFundingRWAStrategyPreparationsPart1_20231229 | 3.418 | 21.158 | | AaveV3Scroll | 0.045 | 24.531 | | AaveV3ScrollAssets | 0.045 | 24.531 | | AaveV3ScrollEModes | 0.045 | 24.531 | | AaveV3Scroll_AaveV3ScrollActivation_20240122 | 6.6 | 17.976 | | AaveV3Scroll_V3PeripheryMaintenance_20240314 | 0.25 | 24.326 | | Address | 0.045 | 24.531 | | ChainHelpers | 0.045 | 24.531 | | ChainIds | 0.045 | 24.531 | | ConfiguratorInputTypes | 0.045 | 24.531 | | Create2Utils | 0.123 | 24.453 | | DataTypes | 0.045 | 24.531 | | EngineFlags | 0.045 | 24.531 | | EnumerableSet | 0.045 | 24.531 | | EnvelopeUtils | 0.045 | 24.531 | | Errors | 4.673 | 19.903 | | GhoInterestRateStrategy | 0.671 | 23.905 | | Gho_GHOStabilityModule_20240119 | 4.494 | 20.082 | | GovHelpers | 0.045 | 24.531 | | GovV3Helpers | 2.581 | 21.995 | | GovV3StorageHelpers | 0.045 | 24.531 | | GovernanceV3Arbitrum | 0.045 | 24.531 | | GovernanceV3Avalanche | 0.045 | 24.531 | | GovernanceV3BNB | 0.045 | 24.531 | | GovernanceV3Base | 0.045 | 24.531 | | GovernanceV3Ethereum | 0.045 | 24.531 | | GovernanceV3Gnosis | 0.045 | 24.531 | | GovernanceV3Metis | 0.045 | 24.531 | | GovernanceV3Optimism | 0.045 | 24.531 | | GovernanceV3Polygon | 0.045 | 24.531 | | GovernanceV3PolygonZkEvm | 0.045 | 24.531 | | GovernanceV3Scroll | 0.045 | 24.531 | | IpfsUtils | 0.045 | 24.531 | | MainnetPayload | 2.583 | 21.993 | | MiscEthereum | 0.045 | 24.531 | | MiscPolygon | 0.045 | 24.531 | | MiscScroll | 0.045 | 24.531 | | MockExecutor | 0.396 | 24.18 | | OrbitProgramData | 0.488 | 24.088 | | ParaswapClaim | 0.022 | 24.554 | | ParaswapClaimer | 0.159 | 24.417 | | Payloads | 0.484 | 24.092 | | PayloadsControllerUtils | 0.045 | 24.531 | | PayloadsToDeploy | 0.045 | 24.531 | | PolygonPayload | 1.593 | 22.983 | | PoolAddresses | 0.316 | 24.26 | | ProxyHelpers | 0.045 | 24.531 | | ReserveConfiguration | 0.13 | 24.446 | | RewardsDataTypes | 0.045 | 24.531 | | SafeERC20 | 0.045 | 24.531 | | StataPayloads | 0.045 | 24.531 | | StorageHelpers | 0.045 | 24.531 | | TransactionUtils | 0.045 | 24.531 | | WadRayMath | 0.045 | 24.531 | ```
Test error :finnadie::x: ```shell No files changed, compilation skipped 2024-03-21T13:15:35.262255Z ERROR sharedbackend: Failed to send/recv `basic` err=failed to get account for 0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f: Server returned an error response: error code -32000: missing trie node 2f18c1b9fb20869a968abea676004513f7130db63cdf9f9dd228a54cffe4f4cc (path ) state 0x2f18c1b9fb20869a968abea676004513f7130db63cdf9f9dd228a54cffe4f4cc is not available, not found address=0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f 2024-03-21T13:15:35.262307Z ERROR sharedbackend: It looks like you're trying to fork from an older block with a non-archive node which is not supported. Please try to change your RPC url to an archive node if the issue persists. Ran 1 test for src/20240312_Multi_StablecoinHarmonization/AaveV3Arbitrum_StablecoinHarmonization_20240312.t.sol:AaveV3Arbitrum_StablecoinHarmonization_20240312_Test [FAIL. Reason: setup failed: backend: failed while inspecting] setUp() (gas: 0) Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 16.50s (0.00ns CPU time) Ran 1 test suite in 16.51s (16.50s CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests) Failing tests: Encountered 1 failing test in src/20240312_Multi_StablecoinHarmonization/AaveV3Arbitrum_StablecoinHarmonization_20240312.t.sol:AaveV3Arbitrum_StablecoinHarmonization_20240312_Test [FAIL. Reason: setup failed: backend: failed while inspecting] setUp() (gas: 0) Encountered a total of 1 failing tests, 0 tests succeeded No files changed, compilation skipped Ran 1 test for src/20240312_Multi_StablecoinHarmonization/AaveV3Avalanche_StablecoinHarmonization_20240312.t.sol:AaveV3Avalanche_StablecoinHarmonization_20240312_Test [PASS] test_defaultProposalExecution() (gas: 39180220) Logs: 0xd586E7F844cEa2F87f50152665BCbc2C279D8d70 0x5947BB275c521040051D82396192181b413227A3 0xB97EF9Ef8734C71904D8002F8b6Bc66Dd9c48a6E 0x50b7545627a5162F82A992c33b87aDc75187B218 0x49D5c2BdFfac6CE2BFdB6640F4F80f226bc10bAB 0x9702230A8Ea53601f5cD2dc00fDBc13d4dF4A8c7 0xB31f66AA3C1e785363F0875A1B74E27b85FD66c7 0xD24C2Ad096400B6FBcd2ad8B24E7acBc21A1da64 0x5c49b268c9841AFF1Cc3B0a418ff5c3442eE3F3b 0x152b9d0FdC40C096757F570A51E494bd4b943E50 E2E: Collateral DAI.e, TestAsset DAI.e SUPPLY: DAI.e, Amount: 100077352788290653494805 SUPPLY: DAI.e, Amount: 1000773527882906534948 WITHDRAW: DAI.e, Amount: 500386763941453267474 WITHDRAW: DAI.e, Amount: 500386763941453267474 BORROW: DAI.e, Amount 1000773527882906534948, Stable: false REPAY: DAI.e, Amount: 1000773527882906534948 E2E: Collateral DAI.e, TestAsset LINK.e SUPPLY: DAI.e, Amount: 100077352788290653494805 SUPPLY: LINK.e, Amount: 47496461513617235515 WITHDRAW: LINK.e, Amount: 23748230756808617757 WITHDRAW: LINK.e, Amount: 23748230756808617757 BORROW: LINK.e, Amount 47496461513617235515, Stable: false REPAY: LINK.e, Amount: 47496461513617235515 E2E: Collateral DAI.e, TestAsset USDC SUPPLY: DAI.e, Amount: 100077352788290653494805 SUPPLY: USDC, Amount: 1000168288 WITHDRAW: USDC, Amount: 500084144 WITHDRAW: USDC, Amount: 500084144 BORROW: USDC, Amount 1000168288, Stable: false REPAY: USDC, Amount: 1000168288 E2E: TestAsset WBTC.e SKIPPED E2E: Collateral DAI.e, TestAsset WETH.e SUPPLY: DAI.e, Amount: 100077352788290653494805 SUPPLY: WETH.e, Amount: 246469954770119416 WITHDRAW: WETH.e, Amount: 123234977385059708 WITHDRAW: WETH.e, Amount: 123234977385059708 BORROW: WETH.e, Amount 246469954770119416, Stable: false REPAY: WETH.e, Amount: 246469954770119416 E2E: Collateral DAI.e, TestAsset USDt SUPPLY: DAI.e, Amount: 100077352788290653494805 SUPPLY: USDt, Amount: 999730072 WITHDRAW: USDt, Amount: 499865036 WITHDRAW: USDt, Amount: 499865036 BORROW: USDt, Amount 999730072, Stable: false REPAY: USDt, Amount: 999730072 E2E: Collateral DAI.e, TestAsset AAVE.e SUPPLY: DAI.e, Amount: 100077352788290653494805 SUPPLY: AAVE.e, Amount: 7415473945683868794 WITHDRAW: AAVE.e, Amount: 3707736972841934397 WITHDRAW: AAVE.e, Amount: 3707736972841934398 E2E: Collateral DAI.e, TestAsset WAVAX SUPPLY: DAI.e, Amount: 100077352788290653494805 SUPPLY: WAVAX, Amount: 20461276952851603530 WITHDRAW: WAVAX, Amount: 10230638476425801765 WITHDRAW: WAVAX, Amount: 10230638476425801766 BORROW: WAVAX, Amount 20461276952851603530, Stable: false REPAY: WAVAX, Amount: 20461276952851603530 E2E: Collateral DAI.e, TestAsset sAVAX SUPPLY: DAI.e, Amount: 100077352788290653494805 SUPPLY: sAVAX, Amount: 18013836354207214236 WITHDRAW: sAVAX, Amount: 9006918177103607118 WITHDRAW: sAVAX, Amount: 9006918177103607118 E2E: Collateral DAI.e, TestAsset FRAX SUPPLY: DAI.e, Amount: 100077352788290653494805 SUPPLY: FRAX, Amount: 1002215095804747653263 WITHDRAW: FRAX, Amount: 501107547902373826631 WITHDRAW: FRAX, Amount: 501107547902373826632 BORROW: FRAX, Amount 1002215095804747653263, Stable: false REPAY: FRAX, Amount: 1002215095804747653263 E2E: TestAsset MAI SKIPPED E2E: Collateral DAI.e, TestAsset BTC.b SUPPLY: DAI.e, Amount: 100077352788290653494805 SUPPLY: BTC.b, Amount: 1382856 WITHDRAW: BTC.b, Amount: 691428 WITHDRAW: BTC.b, Amount: 691428 BORROW: BTC.b, Amount 1382856, Stable: false REPAY: BTC.b, Amount: 1382856 Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 82.45s (82.03s CPU time) Ran 1 test suite in 82.46s (82.45s CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests) No files changed, compilation skipped 2024-03-21T13:22:23.351577Z ERROR sharedbackend: Failed to send/recv `storage` err=failed to get storage for 0x2c1d072e956AFFC0D435Cb7AC38EF18d24d9127c at 2: Error during transport: Max retries exceeded address=0x2c1d072e956AFFC0D435Cb7AC38EF18d24d9127c index=2 Ran 1 test for src/20240312_Multi_StablecoinHarmonization/AaveV3Ethereum_StablecoinHarmonization_20240312.t.sol:AaveV3Ethereum_StablecoinHarmonization_20240312_Test [FAIL. Reason: backend: failed while inspecting] test_defaultProposalExecution() (gas: 0) Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 324.71s (324.02s CPU time) Ran 1 test suite in 324.72s (324.71s CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests) Failing tests: Encountered 1 failing test in src/20240312_Multi_StablecoinHarmonization/AaveV3Ethereum_StablecoinHarmonization_20240312.t.sol:AaveV3Ethereum_StablecoinHarmonization_20240312_Test [FAIL. Reason: backend: failed while inspecting] test_defaultProposalExecution() (gas: 0) Encountered a total of 1 failing tests, 0 tests succeeded No files changed, compilation skipped Ran 1 test for src/20240312_Multi_StablecoinHarmonization/AaveV3Gnosis_StablecoinHarmonization_20240312.t.sol:AaveV3Gnosis_StablecoinHarmonization_20240312_Test [PASS] test_defaultProposalExecution() (gas: 18310856) Logs: 0x6A023CCd1ff6F2045C3309768eAd9E68F978f6e1 0x6C76971f98945AE98dD7d4DFcA8711ebea946eA6 0x9C58BAcC331c9aa871AFD802DB6379a98e80CEdb 0xDDAfbb505ad214D7b80b1f830fcCc89B60fb7A83 0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d 0xcB444e90D8198415266c6a2724b7900fb12FC56E E2E: Collateral WETH, TestAsset WETH SUPPLY: WETH, Amount: 24583233437315658014 SUPPLY: WETH, Amount: 245832334373156580 WITHDRAW: WETH, Amount: 122916167186578290 WITHDRAW: WETH, Amount: 122916167186578290 BORROW: WETH, Amount 245832334373156580, Stable: false REPAY: WETH, Amount: 245832334373156580 E2E: Collateral WETH, TestAsset wstETH SUPPLY: WETH, Amount: 24583233437315658014 SUPPLY: wstETH, Amount: 211930188636387596 WITHDRAW: wstETH, Amount: 105965094318193798 WITHDRAW: wstETH, Amount: 105965094318193798 BORROW: wstETH, Amount 211930188636387596, Stable: false REPAY: wstETH, Amount: 211930188636387596 E2E: Collateral WETH, TestAsset GNO SUPPLY: WETH, Amount: 24583233437315658014 SUPPLY: GNO, Amount: 2267338807865148119 WITHDRAW: GNO, Amount: 1133669403932574059 WITHDRAW: GNO, Amount: 1133669403932574061 BORROW: GNO, Amount 2267338807865148119, Stable: false REPAY: GNO, Amount: 2267338807865148119 E2E: Collateral WETH, TestAsset USDC SUPPLY: WETH, Amount: 24583233437315658014 SUPPLY: USDC, Amount: 1000127456 WITHDRAW: USDC, Amount: 500063728 WITHDRAW: USDC, Amount: 500063728 BORROW: USDC, Amount 1000127456, Stable: false REPAY: USDC, Amount: 1000127456 E2E: Collateral WETH, TestAsset WXDAI SUPPLY: WETH, Amount: 24583233437315658014 SUPPLY: WXDAI, Amount: 999480470051667143418 WITHDRAW: WXDAI, Amount: 499740235025833571709 WITHDRAW: WXDAI, Amount: 499740235025833571709 BORROW: WXDAI, Amount 999480470051667143418, Stable: false REPAY: WXDAI, Amount: 999480470051667143418 E2E: Collateral WETH, TestAsset EURe SUPPLY: WETH, Amount: 24583233437315658014 SUPPLY: EURe, Amount: 915047033417517660407 WITHDRAW: EURe, Amount: 457523516708758830203 WITHDRAW: EURe, Amount: 457523516708758830203 BORROW: EURe, Amount 915047033417517660407, Stable: false REPAY: EURe, Amount: 915047033417517660407 E2E: Collateral WETH, TestAsset sDAI SUPPLY: WETH, Amount: 24583233437315658014 SUPPLY: sDAI, Amount: 955005826824801497502 WITHDRAW: sDAI, Amount: 477502913412400748751 WITHDRAW: sDAI, Amount: 477502913412400748751 Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 64.17s (63.67s CPU time) Ran 1 test suite in 64.17s (64.17s CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests) No files changed, compilation skipped Ran 1 test for src/20240312_Multi_StablecoinHarmonization/AaveV3Metis_StablecoinHarmonization_20240312.t.sol:AaveV3Metis_StablecoinHarmonization_20240312_Test [PASS] test_defaultProposalExecution() (gas: 11830957) Logs: 0x4c078361FC9BbB78DF910800A991C7c3DD2F6ce0 0xDeadDeAddeAddEAddeadDEaDDEAdDeaDDeAD0000 0xEA32A96608495e54156Ae48931A7c20f0dcc1a21 0xbB06DCA3AE6887fAbF931640f67cab3e3a16F4dC 0x420000000000000000000000000000000000000A E2E: Collateral m.DAI, TestAsset m.DAI SUPPLY: m.DAI, Amount: 100006000360021601296077 SUPPLY: m.DAI, Amount: 1000060003600216012960 WITHDRAW: m.DAI, Amount: 500030001800108006480 WITHDRAW: m.DAI, Amount: 500030001800108006480 BORROW: m.DAI, Amount 1000060003600216012960, Stable: false REPAY: m.DAI, Amount: 1000060003600216012960 E2E: Collateral m.DAI, TestAsset Metis SUPPLY: m.DAI, Amount: 100006000360021601296077 SUPPLY: Metis, Amount: 7487900929684203865 WITHDRAW: Metis, Amount: 3743950464842101932 WITHDRAW: Metis, Amount: 3743950464842101933 BORROW: Metis, Amount 7487900929684203865, Stable: false REPAY: Metis, Amount: 7487900929684203865 E2E: Collateral m.DAI, TestAsset m.USDC SUPPLY: m.DAI, Amount: 100006000360021601296077 SUPPLY: m.USDC, Amount: 999988220 WITHDRAW: m.USDC, Amount: 499994110 WITHDRAW: m.USDC, Amount: 499994110 BORROW: m.USDC, Amount 999988220, Stable: false REPAY: m.USDC, Amount: 999988220 E2E: Collateral m.DAI, TestAsset m.USDT SUPPLY: m.DAI, Amount: 100006000360021601296077 SUPPLY: m.USDT, Amount: 999724296 WITHDRAW: m.USDT, Amount: 499862148 WITHDRAW: m.USDT, Amount: 499862148 BORROW: m.USDT, Amount 999724296, Stable: false REPAY: m.USDT, Amount: 999724296 E2E: Collateral m.DAI, TestAsset WETH SUPPLY: m.DAI, Amount: 100006000360021601296077 SUPPLY: WETH, Amount: 246375957503630830 WITHDRAW: WETH, Amount: 123187978751815415 WITHDRAW: WETH, Amount: 123187978751815415 BORROW: WETH, Amount 246375957503630830, Stable: false REPAY: WETH, Amount: 246375957503630830 Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 29.22s (28.52s CPU time) Ran 1 test suite in 29.22s (29.22s CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests) No files changed, compilation skipped 2024-03-21T13:24:54.046073Z ERROR sharedbackend: Failed to send/recv `basic` err=failed to get account for 0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f: Server returned an error response: error code -32000: missing trie node 5e17ce508919a58eae4c79584166c75d6b7262ee2a5af7da84d749b7412462e5 (path ) state 0x5e17ce508919a58eae4c79584166c75d6b7262ee2a5af7da84d749b7412462e5 is not available, not found address=0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f 2024-03-21T13:24:54.046121Z ERROR sharedbackend: It looks like you're trying to fork from an older block with a non-archive node which is not supported. Please try to change your RPC url to an archive node if the issue persists. Ran 1 test for src/20240312_Multi_StablecoinHarmonization/AaveV3Optimism_StablecoinHarmonization_20240312.t.sol:AaveV3Optimism_StablecoinHarmonization_20240312_Test [FAIL. Reason: setup failed: backend: failed while inspecting] setUp() (gas: 0) Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 55.87s (0.00ns CPU time) Ran 1 test suite in 55.88s (55.87s CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests) Failing tests: Encountered 1 failing test in src/20240312_Multi_StablecoinHarmonization/AaveV3Optimism_StablecoinHarmonization_20240312.t.sol:AaveV3Optimism_StablecoinHarmonization_20240312_Test [FAIL. Reason: setup failed: backend: failed while inspecting] setUp() (gas: 0) Encountered a total of 1 failing tests, 0 tests succeeded No files changed, compilation skipped 2024-03-21T13:29:30.751303Z ERROR sharedbackend: Failed to send/recv `storage` err=failed to get storage for 0x794a61358D6845594F94dc1DB02A252b5b4814aD at 66991901324512297130761208943075742137955235603987024760513056972191770825028: Server returned an error response: error code -32603: no response address=0x794a61358D6845594F94dc1DB02A252b5b4814aD index=66991901324512297130761208943075742137955235603987024760513056972191770825028 Ran 1 test for src/20240312_Multi_StablecoinHarmonization/AaveV3Polygon_StablecoinHarmonization_20240312.t.sol:AaveV3Polygon_StablecoinHarmonization_20240312_Test [FAIL. Reason: backend: failed while inspecting] test_defaultProposalExecution() (gas: 0) Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 276.25s (249.78s CPU time) Ran 1 test suite in 276.25s (276.25s CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests) Failing tests: Encountered 1 failing test in src/20240312_Multi_StablecoinHarmonization/AaveV3Polygon_StablecoinHarmonization_20240312.t.sol:AaveV3Polygon_StablecoinHarmonization_20240312_Test [FAIL. Reason: backend: failed while inspecting] test_defaultProposalExecution() (gas: 0) Encountered a total of 1 failing tests, 0 tests succeeded ```
eboadom commented 3 months ago

Regarding assets (not so technical, but consistency-wise), the proposal is consistent with the table on Snapshot, but considering certain assets as "long-tail" collaterals while the following not seems completely inconsistent:

Ethereum

Polygon

marczeller commented 3 months ago

-removed ETH UNI & BAL Freeze -removed polygon EURS change

Updated forum post

Rest of remarks will be implemented after governance decision with a second payload

brotherlymite commented 3 months ago

For the assets being freezed, I think it makes sense to change the LTV to 0 as well. In v3.1.0, it should happen by default when an asset is being freezed - but for now I think setting it manually makes sense.

For alternative stablecoins except USDC, USDT are we very strict to set LTV 0 and LT reduction by 3%? If so,

marczeller commented 3 months ago

For the assets being freezed, I think it makes sense to change the LTV to 0 as well. In v3.1.0, it should happen by default when an asset is being freezed - but for now I think setting it manually makes sense.

For alternative stablecoins except USDC, USDT are we very strict to set LTV 0 and LT reduction by 3%? If so,

  • No changes to sUSD on optimism?
  • No reserve factor update on EURe on gnosis? also sDAI

sUSD implemented RF but no offboarding as there's a use case with synthetix there EURe RF implemented but sDAI can't be borrowed so no implementation to do

eboadom commented 3 months ago

@marczeller I assume keeping the LT reduction of UNI and BAL is on purpose, even if this https://governance.aave.com/t/arfc-stablecoin-harmonization-and-asset-parameters-optimization/16802/7 ?

marczeller commented 3 months ago

@marczeller I assume keeping the LT reduction of UNI and BAL is on purpose, even if this https://governance.aave.com/t/arfc-stablecoin-harmonization-and-asset-parameters-optimization/16802/7 ?

that is correct. we will add an option in snapshot vote to revert this, not change anything or confirm LT reduction allowing governance to decide.