Parameter Recommendations - sUSD on V3 Optimism

[yoavigra]

Discussion - https://governance.aave.com/t/arfc-chaos-labs-parameter-recommendations-susd-on-v3-optimism-05-23-2024/17779#susd-exposure-on-aave-4

Testing question: Is there any way testing on the t.sol file a parameters changes on emode category?

[rustboyar]

Discussion - https://governance.aave.com/t/arfc-chaos-labs-parameter-recommendations-susd-on-v3-optimism-05-23-2024/17779#susd-exposure-on-aave-4

Testing question: Is there any way testing on the t.sol file a parameters changes on emode category?

i think you can use: AaveV3Optimism.POOL.getEModeCategoryData(id);

[yoavigra]

Discussion - https://governance.aave.com/t/arfc-chaos-labs-parameter-recommendations-susd-on-v3-optimism-05-23-2024/17779#susd-exposure-on-aave-4 Testing question: Is there any way testing on the t.sol file a parameters changes on emode category?

i think you can use: AaveV3Optimism.POOL.getEModeCategoryData(id);

@rustboyar Thank you, updated the test accordingly,

[github-actions[bot]]

Foundry report

forge 0.2.0 (5494c33 2024-05-30T00:18:25.357590022Z)

Build log

```shell Compiling 274 files with Solc 0.8.19 Solc 0.8.19 finished in 135.92s Compiler run successful with warnings: Warning (3628): This contract has a payable fallback function, but no receive ether function. Consider adding a receive ether function. --> src/20240502_AaveV1Ethereum_AaveV1Deprecation/AaveV1Ethereum_AaveV1Deprecation_20240502.t.sol:94:1: | 94 | contract AaveV1Ethereum_AaveV1Deprecation_20240502_Test is ProtocolV3TestBase { | ^ (Relevant source part starts here and spans across multiple lines). Note: The payable fallback function is defined here. --> src/20240502_AaveV1Ethereum_AaveV1Deprecation/AaveV1Ethereum_AaveV1Deprecation_20240502.t.sol:297:3: | 297 | fallback() external payable {} | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | Contract | Size (B) | Margin (B) | |---------------------------------------------------------------------------|----------|------------| | AaveGovernanceV2 | 45 | 24,531 | | AaveSafetyModule | 45 | 24,531 | | AaveSwapper | 5,572 | 19,004 | | AaveV1 | 45 | 24,531 | | AaveV1Ethereum_AaveV1Deprecation_20240502 | 2,593 | 21,983 | | AaveV2Avalanche | 45 | 24,531 | | AaveV2AvalancheAssets | 45 | 24,531 | | AaveV2Avalanche_LTLTVReductionsOnAaveV2Stablecoins_20240510 | 210 | 24,366 | | AaveV2Avalanche_MigrateRobotsToChainlinkAutomationV2_20240422 | 518 | 24,058 | | AaveV2Avalanche_ReserveFactorUpgrades_20240506 | 1,022 | 23,554 | | AaveV2Avalanche_ReserveFactorUpgrades_20240524 | 1,022 | 23,554 | | AaveV2Avalanche_StablecoinIRUpdates_20240424 | 1,858 | 22,718 | | AaveV2Avalanche_TemporaryFreezeOfLongTailV2Assets_20240418 | 186 | 24,390 | | AaveV2Ethereum | 45 | 24,531 | | AaveV2EthereumAMM | 45 | 24,531 | | AaveV2EthereumAMMAssets | 45 | 24,531 | | AaveV2EthereumAssets | 45 | 24,531 | | AaveV2Ethereum_AAMPLSecondDistribution_20240429 | 2,370 | 22,206 | | AaveV2Ethereum_AprilFinanceUpdate_20240421 | 7,897 | 16,679 | | AaveV2Ethereum_ChaosLabsEthereumV2LTReductions_20240509 | 358 | 24,218 | | AaveV2Ethereum_DeprecationOfSmallCapStablecoinsOnV2Ethereum_20240502 | 3,472 | 21,104 | | AaveV2Ethereum_LTLTVReductionsOnAaveV2Stablecoins_20240510 | 210 | 24,366 | | AaveV2Ethereum_ReserveFactorUpgrades_20240506 | 1,778 | 22,798 | | AaveV2Ethereum_ReserveFactorUpgrades_20240524 | 1,778 | 22,798 | | AaveV2Ethereum_StablecoinIRUpdates_20240424 | 1,858 | 22,718 | | AaveV2Ethereum_TemporaryFreezeOfLongTailV2Assets_20240418 | 793 | 23,783 | | AaveV2Polygon | 45 | 24,531 | | AaveV2PolygonAssets | 45 | 24,531 | | AaveV2Polygon_AprilFinanceUpdate_20240421 | 6,129 | 18,447 | | AaveV2Polygon_AprilFinanceUpdate_20240421_PartB | 451 | 24,125 | | AaveV2Polygon_LTLTVReductionsOnAaveV2Stablecoins_20240510 | 210 | 24,366 | | AaveV2Polygon_MigrateRobotsToChainlinkAutomationV2_20240422 | 518 | 24,058 | | AaveV2Polygon_TemporaryFreezeOfLongTailV2Assets_20240418 | 186 | 24,390 | | AaveV3Arbitrum | 45 | 24,531 | | AaveV3ArbitrumAssets | 45 | 24,531 | | AaveV3ArbitrumEModes | 45 | 24,531 | | AaveV3Arbitrum_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,669 | 20,907 | | AaveV3Arbitrum_MigrateRobotsToChainlinkAutomationV2_20240422 | 2,954 | 21,622 | | AaveV3Arbitrum_StablecoinIRUpdates_20240424 | 5,381 | 19,195 | | AaveV3Avalanche | 45 | 24,531 | | AaveV3AvalancheAssets | 45 | 24,531 | | AaveV3AvalancheEModes | 45 | 24,531 | | AaveV3Avalanche_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,377 | 21,199 | | AaveV3Avalanche_MigrateRobotsToChainlinkAutomationV2_20240422 | 3,577 | 20,999 | | AaveV3Avalanche_StablecoinIRUpdates_20240424 | 4,628 | 19,948 | | AaveV3BNB | 45 | 24,531 | | AaveV3BNBAssets | 45 | 24,531 | | AaveV3BNBEModes | 45 | 24,531 | | AaveV3BNB_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,528 | 21,048 | | AaveV3BNB_StablecoinIRUpdates_20240424 | 4,132 | 20,444 | | AaveV3Base | 45 | 24,531 | | AaveV3BaseAssets | 45 | 24,531 | | AaveV3BaseEModes | 45 | 24,531 | | AaveV3Base_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,517 | 21,059 | | AaveV3Base_StablecoinIRUpdates_20240424 | 3,868 | 20,708 | | AaveV3Base_WeETHAaveV3BaseOnboarding_20240527 | 4,997 | 19,579 | | AaveV3Ethereum | 45 | 24,531 | | AaveV3EthereumAssets | 45 | 24,531 | | AaveV3EthereumEModes | 45 | 24,531 | | AaveV3Ethereum_ACIAdAstra_20240506 | 835 | 23,741 | | AaveV3Ethereum_AaveV31CantinaCompetition_20240503 | 344 | 24,232 | | AaveV3Ethereum_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,669 | 20,907 | | AaveV3Ethereum_LlamariskRiskProvider_20240421 | 641 | 23,935 | | AaveV3Ethereum_MigrateRobotsToChainlinkAutomationV2_20240422 | 5,800 | 18,776 | | AaveV3Ethereum_OrbitProgramRenewal_20240513 | 1,670 | 22,906 | | AaveV3Ethereum_StablecoinIRUpdates_20240424 | 5,130 | 19,446 | | AaveV3Ethereum_StkGHOIncentives_20240424 | 1,476 | 23,100 | | AaveV3Ethereum_UpdatingWeETHRiskParameters_20240426 | 4,111 | 20,465 | | AaveV3Gnosis | 45 | 24,531 | | AaveV3GnosisAssets | 45 | 24,531 | | AaveV3GnosisEModes | 45 | 24,531 | | AaveV3Gnosis_AprilFinanceUpdate_20240421 | 380 | 24,196 | | AaveV3Gnosis_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,519 | 21,057 | | AaveV3Gnosis_StablecoinIRUpdates_20240424 | 4,123 | 20,453 | | AaveV3Optimism | 45 | 24,531 | | AaveV3OptimismAssets | 45 | 24,531 | | AaveV3OptimismEModes | 45 | 24,531 | | AaveV3Optimism_ChaosLabsParameterRecommendationsSUSDOnV3Optimism_20240528 | 3,973 | 20,603 | | AaveV3Optimism_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,669 | 20,907 | | AaveV3Optimism_MigrateRobotsToChainlinkAutomationV2_20240422 | 2,844 | 21,732 | | AaveV3Optimism_SUSDRiskParametersUpdate_20240517 | 3,372 | 21,204 | | AaveV3Optimism_StablecoinIRUpdates_20240424 | 5,130 | 19,446 | | AaveV3Polygon | 45 | 24,531 | | AaveV3PolygonAssets | 45 | 24,531 | | AaveV3PolygonEModes | 45 | 24,531 | | AaveV3Polygon_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,668 | 20,908 | | AaveV3Polygon_MigrateRobotsToChainlinkAutomationV2_20240422 | 2,773 | 21,803 | | AaveV3Polygon_StablecoinIRUpdates_20240424 | 5,380 | 19,196 | | AaveV3Scroll | 45 | 24,531 | | AaveV3ScrollAssets | 45 | 24,531 | | AaveV3ScrollEModes | 45 | 24,531 | | AaveV3Scroll_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,374 | 21,202 | | AaveV3Scroll_StablecoinIRUpdates_20240424 | 3,620 | 20,956 | | Address | 45 | 24,531 | | ChainHelpers | 45 | 24,531 | | ChainIds | 45 | 24,531 | | ConfiguratorInputTypes | 45 | 24,531 | | Create2Utils | 123 | 24,453 | | DataTypes | 45 | 24,531 | | EngineFlags | 45 | 24,531 | | Errors | 4,673 | 19,903 | | GovV3Helpers | 2,581 | 21,995 | | GovV3StorageHelpers | 45 | 24,531 | | GovernanceV3Arbitrum | 45 | 24,531 | | GovernanceV3Avalanche | 45 | 24,531 | | GovernanceV3BNB | 45 | 24,531 | | GovernanceV3Base | 45 | 24,531 | | GovernanceV3Ethereum | 45 | 24,531 | | GovernanceV3Gnosis | 45 | 24,531 | | GovernanceV3Metis | 45 | 24,531 | | GovernanceV3Optimism | 45 | 24,531 | | GovernanceV3Polygon | 45 | 24,531 | | GovernanceV3PolygonZkEvm | 45 | 24,531 | | GovernanceV3Scroll | 45 | 24,531 | | IpfsUtils | 45 | 24,531 | | MiscEthereum | 45 | 24,531 | | MiscPolygon | 45 | 24,531 | | OrbitProgramData | 422 | 24,154 | | PayloadsControllerUtils | 45 | 24,531 | | ProxyHelpers | 45 | 24,531 | | ReserveConfiguration | 130 | 24,446 | | SafeCast | 45 | 24,531 | | SafeERC20 | 45 | 24,531 | | StorageHelpers | 45 | 24,531 | | WadRayMath | 45 | 24,531 | ```

Test error :finnadie::x:

```shell No files changed, compilation skipped 2024-05-30T17:22:26.655836Z ERROR sharedbackend: Failed to send/recv `basic` err=failed to get account for 0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f: server returned an error response: error code -32000: missing trie node 22f7f5f97545a3e3ac54fe707ea0fbc323949b67c21ce3f4d9f35587cad6d79a (path ) state 0x22f7f5f97545a3e3ac54fe707ea0fbc323949b67c21ce3f4d9f35587cad6d79a is not available, not found address=0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f 2024-05-30T17:22:26.655864Z ERROR sharedbackend: It looks like you're trying to fork from an older block with a non-archive node which is not supported. Please try to change your RPC url to an archive node if the issue persists. Ran 1 test for src/20240528_AaveV3Optimism_ChaosLabsParameterRecommendationsSUSDOnV3Optimism/AaveV3Optimism_ChaosLabsParameterRecommendationsSUSDOnV3Optimism_20240528.t.sol:AaveV3Optimism_ChaosLabsParameterRecommendationsSUSDOnV3Optimism_20240528_Test [FAIL. Reason: setup failed: backend: failed while inspecting] setUp() (gas: 0) Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 380.02ms (0.00ns CPU time) Ran 1 test suite in 400.23ms (380.02ms CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests) Failing tests: Encountered 1 failing test in src/20240528_AaveV3Optimism_ChaosLabsParameterRecommendationsSUSDOnV3Optimism/AaveV3Optimism_ChaosLabsParameterRecommendationsSUSDOnV3Optimism_20240528.t.sol:AaveV3Optimism_ChaosLabsParameterRecommendationsSUSDOnV3Optimism_20240528_Test [FAIL. Reason: setup failed: backend: failed while inspecting] setUp() (gas: 0) Encountered a total of 1 failing tests, 0 tests succeeded ```