bgd-labs / aave-proposals-v3

MIT License
16 stars 18 forks source link

[Chaos Labs] Risk Parameter Updates - Aave V3 #347

Closed dyamin closed 3 weeks ago

dyamin commented 4 weeks ago

Discussion: https://governance.aave.com/t/arfc-chaos-labs-risk-parameter-updates-aave-v3-05-24-2024/17788/1

github-actions[bot] commented 3 weeks ago

Foundry report

forge 0.2.0 (fb86e5d 2024-06-05T00:17:41.128117927Z)
Build log ```shell Compiling 300 files with Solc 0.8.19 Solc 0.8.19 finished in 159.70s Compiler run successful with warnings: Warning (3628): This contract has a payable fallback function, but no receive ether function. Consider adding a receive ether function. --> src/20240502_AaveV1Ethereum_AaveV1Deprecation/AaveV1Ethereum_AaveV1Deprecation_20240502.t.sol:94:1: | 94 | contract AaveV1Ethereum_AaveV1Deprecation_20240502_Test is ProtocolV3TestBase { | ^ (Relevant source part starts here and spans across multiple lines). Note: The payable fallback function is defined here. --> src/20240502_AaveV1Ethereum_AaveV1Deprecation/AaveV1Ethereum_AaveV1Deprecation_20240502.t.sol:297:3: | 297 | fallback() external payable {} | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | Contract | Size (B) | Margin (B) | |---------------------------------------------------------------------------|----------|------------| | AaveGovernanceV2 | 45 | 24,531 | | AaveSafetyModule | 45 | 24,531 | | AaveSwapper | 5,572 | 19,004 | | AaveV1 | 45 | 24,531 | | AaveV1Ethereum_AaveV1Deprecation_20240502 | 2,593 | 21,983 | | AaveV2Avalanche | 45 | 24,531 | | AaveV2AvalancheAssets | 45 | 24,531 | | AaveV2Avalanche_LTLTVReductionsOnAaveV2Stablecoins_20240510 | 210 | 24,366 | | AaveV2Avalanche_MigrateRobotsToChainlinkAutomationV2_20240422 | 518 | 24,058 | | AaveV2Avalanche_ReserveFactorUpgrades_20240506 | 1,022 | 23,554 | | AaveV2Avalanche_ReserveFactorUpgrades_20240524 | 1,022 | 23,554 | | AaveV2Avalanche_StablecoinIRUpdates_20240424 | 1,858 | 22,718 | | AaveV2Avalanche_TemporaryFreezeOfLongTailV2Assets_20240418 | 186 | 24,390 | | AaveV2Ethereum | 45 | 24,531 | | AaveV2EthereumAMM | 45 | 24,531 | | AaveV2EthereumAMMAssets | 45 | 24,531 | | AaveV2EthereumAssets | 45 | 24,531 | | AaveV2Ethereum_AAMPLSecondDistribution_20240429 | 2,370 | 22,206 | | AaveV2Ethereum_AprilFinanceUpdate_20240421 | 7,897 | 16,679 | | AaveV2Ethereum_ChaosLabsEthereumV2LTReductions_20240509 | 358 | 24,218 | | AaveV2Ethereum_DeprecationOfSmallCapStablecoinsOnV2Ethereum_20240502 | 3,472 | 21,104 | | AaveV2Ethereum_LTLTVReductionsOnAaveV2Stablecoins_20240510 | 210 | 24,366 | | AaveV2Ethereum_ReserveFactorUpgrades_20240506 | 1,778 | 22,798 | | AaveV2Ethereum_ReserveFactorUpgrades_20240524 | 1,778 | 22,798 | | AaveV2Ethereum_StablecoinIRUpdates_20240424 | 1,858 | 22,718 | | AaveV2Ethereum_TemporaryFreezeOfLongTailV2Assets_20240418 | 793 | 23,783 | | AaveV2Polygon | 45 | 24,531 | | AaveV2PolygonAssets | 45 | 24,531 | | AaveV2Polygon_AprilFinanceUpdate_20240421 | 6,129 | 18,447 | | AaveV2Polygon_AprilFinanceUpdate_20240421_PartB | 451 | 24,125 | | AaveV2Polygon_LTLTVReductionsOnAaveV2Stablecoins_20240510 | 210 | 24,366 | | AaveV2Polygon_MigrateRobotsToChainlinkAutomationV2_20240422 | 518 | 24,058 | | AaveV2Polygon_TemporaryFreezeOfLongTailV2Assets_20240418 | 186 | 24,390 | | AaveV3Arbitrum | 45 | 24,531 | | AaveV3ArbitrumAssets | 45 | 24,531 | | AaveV3ArbitrumEModes | 45 | 24,531 | | AaveV3Arbitrum_AdjustingInterestRateCurveForWeETHOnArbitrum_20240603 | 3,923 | 20,653 | | AaveV3Arbitrum_ChaosLabsRiskParameterUpdatesAaveV3_20240530 | 3,376 | 21,200 | | AaveV3Arbitrum_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,669 | 20,907 | | AaveV3Arbitrum_MigrateRobotsToChainlinkAutomationV2_20240422 | 2,954 | 21,622 | | AaveV3Arbitrum_StablecoinIRUpdates_20240424 | 5,381 | 19,195 | | AaveV3Avalanche | 45 | 24,531 | | AaveV3AvalancheAssets | 45 | 24,531 | | AaveV3AvalancheEModes | 45 | 24,531 | | AaveV3Avalanche_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,377 | 21,199 | | AaveV3Avalanche_MigrateRobotsToChainlinkAutomationV2_20240422 | 3,577 | 20,999 | | AaveV3Avalanche_StablecoinIRUpdates_20240424 | 4,628 | 19,948 | | AaveV3BNB | 45 | 24,531 | | AaveV3BNBAssets | 45 | 24,531 | | AaveV3BNBEModes | 45 | 24,531 | | AaveV3BNB_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,528 | 21,048 | | AaveV3BNB_StablecoinIRUpdates_20240424 | 4,132 | 20,444 | | AaveV3Base | 45 | 24,531 | | AaveV3BaseAssets | 45 | 24,531 | | AaveV3BaseEModes | 45 | 24,531 | | AaveV3Base_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,517 | 21,059 | | AaveV3Base_StablecoinIRUpdates_20240424 | 3,868 | 20,708 | | AaveV3Base_WeETHAaveV3BaseOnboarding_20240527 | 4,997 | 19,579 | | AaveV3Ethereum | 45 | 24,531 | | AaveV3EthereumAssets | 45 | 24,531 | | AaveV3EthereumEModes | 45 | 24,531 | | AaveV3Ethereum_ACIAdAstra_20240506 | 835 | 23,741 | | AaveV3Ethereum_AaveV31CantinaCompetition_20240503 | 344 | 24,232 | | AaveV3Ethereum_AprilFinanceUpdatePartB_20240515 | 4,488 | 20,088 | | AaveV3Ethereum_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,669 | 20,907 | | AaveV3Ethereum_GhoStewardUpdate_20240602 | 2,571 | 22,005 | | AaveV3Ethereum_LlamariskRiskProvider_20240421 | 641 | 23,935 | | AaveV3Ethereum_MigrateRobotsToChainlinkAutomationV2_20240422 | 5,800 | 18,776 | | AaveV3Ethereum_OnboardUSDeAaveV3Ethereum_20240528 | 5,012 | 19,564 | | AaveV3Ethereum_OrbitProgramRenewal_20240513 | 1,670 | 22,906 | | AaveV3Ethereum_StablecoinIRUpdates_20240424 | 5,130 | 19,446 | | AaveV3Ethereum_StkGHOIncentives_20240424 | 1,476 | 23,100 | | AaveV3Ethereum_UpdatingWeETHRiskParameters_20240426 | 4,111 | 20,465 | | AaveV3Gnosis | 45 | 24,531 | | AaveV3GnosisAssets | 45 | 24,531 | | AaveV3GnosisEModes | 45 | 24,531 | | AaveV3Gnosis_AprilFinanceUpdate_20240421 | 380 | 24,196 | | AaveV3Gnosis_ChaosLabsRiskParameterUpdatesAaveV3_20240530 | 3,374 | 21,202 | | AaveV3Gnosis_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,519 | 21,057 | | AaveV3Gnosis_StablecoinIRUpdates_20240424 | 4,123 | 20,453 | | AaveV3Optimism | 45 | 24,531 | | AaveV3OptimismAssets | 45 | 24,531 | | AaveV3OptimismEModes | 45 | 24,531 | | AaveV3Optimism_ChaosLabsParameterRecommendationsSUSDOnV3Optimism_20240528 | 3,973 | 20,603 | | AaveV3Optimism_ChaosLabsRiskParameterUpdatesAaveV3_20240530 | 3,363 | 21,213 | | AaveV3Optimism_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,669 | 20,907 | | AaveV3Optimism_MigrateRobotsToChainlinkAutomationV2_20240422 | 2,844 | 21,732 | | AaveV3Optimism_SUSDRiskParametersUpdate_20240517 | 3,372 | 21,204 | | AaveV3Optimism_StablecoinIRUpdates_20240424 | 5,130 | 19,446 | | AaveV3Polygon | 45 | 24,531 | | AaveV3PolygonAssets | 45 | 24,531 | | AaveV3PolygonEModes | 45 | 24,531 | | AaveV3Polygon_ChaosLabsRiskParameterUpdatesAaveV3_20240530 | 3,520 | 21,056 | | AaveV3Polygon_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,668 | 20,908 | | AaveV3Polygon_MigrateRobotsToChainlinkAutomationV2_20240422 | 2,773 | 21,803 | | AaveV3Polygon_StablecoinIRUpdates_20240424 | 5,380 | 19,196 | | AaveV3Scroll | 45 | 24,531 | | AaveV3ScrollAssets | 45 | 24,531 | | AaveV3ScrollEModes | 45 | 24,531 | | AaveV3Scroll_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425 | 3,374 | 21,202 | | AaveV3Scroll_StablecoinIRUpdates_20240424 | 3,620 | 20,956 | | Address | 45 | 24,531 | | ChainHelpers | 45 | 24,531 | | ChainIds | 45 | 24,531 | | ConfiguratorInputTypes | 45 | 24,531 | | Create2Utils | 123 | 24,453 | | DataTypes | 45 | 24,531 | | EngineFlags | 45 | 24,531 | | Errors | 4,673 | 19,903 | | GovV3Helpers | 2,581 | 21,995 | | GovV3StorageHelpers | 45 | 24,531 | | GovernanceV3Arbitrum | 45 | 24,531 | | GovernanceV3Avalanche | 45 | 24,531 | | GovernanceV3BNB | 45 | 24,531 | | GovernanceV3Base | 45 | 24,531 | | GovernanceV3Ethereum | 45 | 24,531 | | GovernanceV3Gnosis | 45 | 24,531 | | GovernanceV3Metis | 45 | 24,531 | | GovernanceV3Optimism | 45 | 24,531 | | GovernanceV3Polygon | 45 | 24,531 | | GovernanceV3PolygonZkEvm | 45 | 24,531 | | GovernanceV3Scroll | 45 | 24,531 | | IpfsUtils | 45 | 24,531 | | MiscEthereum | 45 | 24,531 | | MiscPolygon | 45 | 24,531 | | OrbitProgramData | 422 | 24,154 | | PayloadsControllerUtils | 45 | 24,531 | | ProxyHelpers | 45 | 24,531 | | ReserveConfiguration | 130 | 24,446 | | SafeCast | 45 | 24,531 | | SafeERC20 | 45 | 24,531 | | StorageHelpers | 45 | 24,531 | | WadRayMath | 45 | 24,531 | ```
Test error :finnadie::x: ```shell No files changed, compilation skipped 2024-06-05T16:11:55.910282Z ERROR sharedbackend: Failed to send/recv `storage` err=failed to get storage for 0x794a61358D6845594F94dc1DB02A252b5b4814aD at 30050040422217791513626964584907808419309843595821202013863270037927612710551: Max retries exceeded address=0x794a61358D6845594F94dc1DB02A252b5b4814aD index=30050040422217791513626964584907808419309843595821202013863270037927612710551 Ran 1 test for src/20240530_Multi_ChaosLabsRiskParameterUpdatesAaveV3/AaveV3Arbitrum_ChaosLabsRiskParameterUpdatesAaveV3_20240530.t.sol:AaveV3Arbitrum_ChaosLabsRiskParameterUpdatesAaveV3_20240530_Test [FAIL. Reason: backend: failed while inspecting] test_defaultProposalExecution() (gas: 0) Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 7.18s (6.97s CPU time) Ran 1 test suite in 7.19s (7.18s CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests) Failing tests: Encountered 1 failing test in src/20240530_Multi_ChaosLabsRiskParameterUpdatesAaveV3/AaveV3Arbitrum_ChaosLabsRiskParameterUpdatesAaveV3_20240530.t.sol:AaveV3Arbitrum_ChaosLabsRiskParameterUpdatesAaveV3_20240530_Test [FAIL. Reason: backend: failed while inspecting] test_defaultProposalExecution() (gas: 0) Encountered a total of 1 failing tests, 0 tests succeeded No files changed, compilation skipped Ran 1 test for src/20240530_Multi_ChaosLabsRiskParameterUpdatesAaveV3/AaveV3Gnosis_ChaosLabsRiskParameterUpdatesAaveV3_20240530.t.sol:AaveV3Gnosis_ChaosLabsRiskParameterUpdatesAaveV3_20240530_Test [PASS] test_defaultProposalExecution() (gas: 18334824) Logs: 0x6A023CCd1ff6F2045C3309768eAd9E68F978f6e1 0x6C76971f98945AE98dD7d4DFcA8711ebea946eA6 0x9C58BAcC331c9aa871AFD802DB6379a98e80CEdb 0xDDAfbb505ad214D7b80b1f830fcCc89B60fb7A83 0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d 0xcB444e90D8198415266c6a2724b7900fb12FC56E E2E: Collateral WETH, TestAsset WETH SUPPLY: WETH, Amount: 26455026455026455026 SUPPLY: WETH, Amount: 264550264550264550 WITHDRAW: WETH, Amount: 132275132275132275 WITHDRAW: WETH, Amount: 132275132275132274 BORROW: WETH, Amount 264550264550264550, Stable: false REPAY: WETH, Amount: 264550264550264550 E2E: Collateral WETH, TestAsset wstETH SUPPLY: WETH, Amount: 26455026455026455026 SUPPLY: wstETH, Amount: 226479262906090587 WITHDRAW: wstETH, Amount: 113239631453045293 WITHDRAW: wstETH, Amount: 113239631453045293 BORROW: wstETH, Amount 226479262906090587, Stable: false REPAY: wstETH, Amount: 226479262906090587 E2E: Collateral WETH, TestAsset GNO SUPPLY: WETH, Amount: 26455026455026455026 SUPPLY: GNO, Amount: 2980001023188119313 WITHDRAW: GNO, Amount: 1490000511594059656 WITHDRAW: GNO, Amount: 1490000511594059657 BORROW: GNO, Amount 2980001023188119313, Stable: false REPAY: GNO, Amount: 2980001023188119313 E2E: Collateral WETH, TestAsset USDC SUPPLY: WETH, Amount: 26455026455026455026 SUPPLY: USDC, Amount: 999950002 WITHDRAW: USDC, Amount: 499975001 WITHDRAW: USDC, Amount: 499975002 BORROW: USDC, Amount 999950002, Stable: false REPAY: USDC, Amount: 999950002 E2E: Collateral WETH, TestAsset WXDAI SUPPLY: WETH, Amount: 26455026455026455026 SUPPLY: WXDAI, Amount: 1000620534824671520043 WITHDRAW: WXDAI, Amount: 500310267412335760021 WITHDRAW: WXDAI, Amount: 500310267412335760022 BORROW: WXDAI, Amount 1000620534824671520043, Stable: false REPAY: WXDAI, Amount: 1000620534824671520043 E2E: Collateral WETH, TestAsset EURe SUPPLY: WETH, Amount: 26455026455026455026 SUPPLY: EURe, Amount: 923113847630828310055 WITHDRAW: EURe, Amount: 461556923815414155027 WITHDRAW: EURe, Amount: 461556923815414155028 BORROW: EURe, Amount 923113847630828310055, Stable: false REPAY: EURe, Amount: 923113847630828310055 E2E: Collateral WETH, TestAsset sDAI SUPPLY: WETH, Amount: 26455026455026455026 SUPPLY: sDAI, Amount: 924803779295726039679 WITHDRAW: sDAI, Amount: 462401889647863019839 WITHDRAW: sDAI, Amount: 462401889647863019840 Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 57.06s (56.35s CPU time) Ran 1 test suite in 57.07s (57.06s CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests) No files changed, compilation skipped 2024-06-05T16:12:54.411439Z ERROR sharedbackend: Failed to send/recv `basic` err=failed to get account for 0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f: server returned an error response: error code -32000: missing trie node 9a0068d8f975b8ec9cd6d906ec4d58f2dedf59f9457b6d9ced0a9438f458eff7 (path ) state 0x9a0068d8f975b8ec9cd6d906ec4d58f2dedf59f9457b6d9ced0a9438f458eff7 is not available, not found address=0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f 2024-06-05T16:12:54.411474Z ERROR sharedbackend: It looks like you're trying to fork from an older block with a non-archive node which is not supported. Please try to change your RPC url to an archive node if the issue persists. Ran 1 test for src/20240530_Multi_ChaosLabsRiskParameterUpdatesAaveV3/AaveV3Optimism_ChaosLabsRiskParameterUpdatesAaveV3_20240530.t.sol:AaveV3Optimism_ChaosLabsRiskParameterUpdatesAaveV3_20240530_Test [FAIL. Reason: setup failed: backend: failed while inspecting] setUp() (gas: 0) Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 405.30ms (0.00ns CPU time) Ran 1 test suite in 411.21ms (405.30ms CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests) Failing tests: Encountered 1 failing test in src/20240530_Multi_ChaosLabsRiskParameterUpdatesAaveV3/AaveV3Optimism_ChaosLabsRiskParameterUpdatesAaveV3_20240530.t.sol:AaveV3Optimism_ChaosLabsRiskParameterUpdatesAaveV3_20240530_Test [FAIL. Reason: setup failed: backend: failed while inspecting] setUp() (gas: 0) Encountered a total of 1 failing tests, 0 tests succeeded No files changed, compilation skipped Ran 1 test for src/20240530_Multi_ChaosLabsRiskParameterUpdatesAaveV3/AaveV3Polygon_ChaosLabsRiskParameterUpdatesAaveV3_20240530.t.sol:AaveV3Polygon_ChaosLabsRiskParameterUpdatesAaveV3_20240530_Test [FAIL. Reason: setup failed: Could not instantiate forked environment with fork url: https://polygon.llamarpc.com] setUp() (gas: 0) Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 137.69s (0.00ns CPU time) Ran 1 test suite in 137.70s (137.69s CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests) Failing tests: Encountered 1 failing test in src/20240530_Multi_ChaosLabsRiskParameterUpdatesAaveV3/AaveV3Polygon_ChaosLabsRiskParameterUpdatesAaveV3_20240530.t.sol:AaveV3Polygon_ChaosLabsRiskParameterUpdatesAaveV3_20240530_Test [FAIL. Reason: setup failed: Could not instantiate forked environment with fork url: https://polygon.llamarpc.com] setUp() (gas: 0) Encountered a total of 1 failing tests, 0 tests succeeded ```