search

bgd-labs / seatbelt-gov-v3

Aave Seatbelt for governance proposals
MIT License
11 stars 3 forks source link

missing number formatting #11

Open sakulstra opened 7 months ago

sakulstra commented 7 months ago

Non exhaustive list of state / events that should be formatted in a human readable way.

MichaelMorami commented 7 months ago

couple of requests: 1) we spotted a bug in the formatting - the sum in the attachment should be 250k. Screenshot 2024-03-17 at 18 33 28

2) We will appreciate it if you can write next to the formatted number and the original number a parentheses with the decimals of the token, e.g. (18 decimals) or (6 decimals)

sakulstra commented 7 months ago

@MichaelMorami should be fixed now: https://github.com/bgd-labs/seatbelt-gov-v3/commit/87ae13365d06815d5fb0b5f9986934fa0121f66c#diff-aa3d4e9122e087d99d2541df91e0902bf67f5a2e33fc04bd337f77a83f4a6727 - lmk if you need any specific report to be reran after the updates.

The 250.000... issue was due to falling big to "just formatting", when not finding the decimals. Fixed the issue to find the decimals in this specific case, but also removed the formatting for the cases we don't.

MichaelMorami commented 7 months ago

Possibly an annoying one: On streams (example) the amount of the deposits are not formatted. It would be nice to have this, but I also understand if you cannot. In the end, it's not super crucial

sakulstra commented 6 months ago

@MichaelMorami streams should now display formatted value & the asset distributed