search

bgentry / speakeasy

cross-platform Golang helpers for reading password input without cgo
Other
115 stars 24 forks source link

Allow specifying output. Closes #1 #2

Closed andrew-d closed 10 years ago

andrew-d commented 10 years ago

As per #1, here's what I was hoping to accomplish.

bgentry commented 10 years ago

@andrew-d this looks pretty good! Can you please

  1. rebase it on master
  2. also refactor this so that the fmt.Println("") in readline() instead happens after the call to getPassword() inside of FAsk() ? As part of this, you'll be able to use fmt.Fprintln() to make that carriage return also appear on a chosen output file (rather than always os.Stdout).

Thanks!

andrew-d commented 10 years ago

Made changes as requested. Let me know if you'd prefer that I squash changes into a single commit :smile:

andrew-d commented 10 years ago

@bgentry Haha, can't believe I missed that. Fixed now :)

bgentry commented 10 years ago

Thanks again for this, and sorry it took me so long to notice this PR :v:

andrew-d commented 10 years ago

No problem - thanks for merging :cake: