bggo / Zmbkpose

The zmbkpose tool is a shell script that does hot backup and hot restore of ZCS Opensource accounts, GPL(OPENSOURCE). It can run from any host in the net, which means that it can be set on a backup server already existent.
http://wiki.zimbra.com/wiki/HOT_Backup_and_HOT_Restore
GNU General Public License v3.0
79 stars 55 forks source link

Push the rewrite #21

Closed bggo closed 12 years ago

bggo commented 12 years ago

Liandros wrote the code from scratch.

I just read it, need's someone to test.

liandros commented 12 years ago

Continue improving the documentation, and reviewing some details before commit. Suggestions are welcome.

marianstefan commented 12 years ago

Hello Liandros,

I have tested you rewrite propossal from https://docs.google.com/open?id=0B9IDNSyRLvcBdVN4cWd6U2ZQUWc First issue noticed was that restore doesn't work:

zmbkpose -r -a email /bin/tar: 20120831115153: Cannot open: No such file or directory /bin/tar: Error is not recoverable: exiting now

It seems that the restore function doesn't properly get the last backup time.

Regards, Marian Stefan

liandros commented 12 years ago

2012/8/31 marianstefan notifications@github.com

Hello Liandros,

I have tested you rewrite propossal from https://docs.google.com/open?id=0B9IDNSyRLvcBdVN4cWd6U2ZQUWc First issue noticed was that restore doesn't work:

zmbkpose -r -a email /bin/tar: 20120831115153: Cannot open: No such file or directory /bin/tar: Error is not recoverable: exiting now

It seems that the restore function doesn't properly get the last backup time.

Please, can you execute with bash -x zmbkpose -r -a email and send me the last lines previous to error

liandros commented 12 years ago

Rewrite proposal pushed as a new branch "rewrite_proposal_v2.0"

marianstefan commented 12 years ago

Hello Liandros,

Nice to have you back. Here is the output of bash -x and ls -lsah

bash -x zmbkpose -r -a email

... ++ read date_time_mark full_inc bkfile ++ '[' -z 20120912115416 ']' ++ '[' 20120912115416 -gt 20120912115436 ']' ++ '[' -z '' -a FULL '!=' FULL ']' ++ '[' -z '' ']' ++ cycles_to_maintain_reached=y ++ continue ++ read date_time_mark full_inc bkfile


zimbra@mx01:~/backup/admin@mx.scsc.ro$ ls -lsah total 20K 4.0K drwxr-x--- 2 zimbra zimbra 4.0K 2012-09-12 11:54 . 4.0K drwxr-xr-x 4 zimbra zimbra 4.0K 2012-09-12 11:54 .. 12K -rw-r----- 1 zimbra zimbra 10K 2012-09-12 11:54 20120912115416:FULL.tar 0 lrwxrwxrwx 1 zimbra zimbra 23 2012-09-12 11:54 LAST -> 20120912115416:FULL.tar

Regards, Marian Stefan

On Tue, Sep 11, 2012 at 1:52 PM, Leandro Santinelli < notifications@github.com> wrote:

2012/8/31 marianstefan notifications@github.com

Hello Liandros,

I have tested you rewrite propossal from https://docs.google.com/open?id=0B9IDNSyRLvcBdVN4cWd6U2ZQUWc First issue noticed was that restore doesn't work:

zmbkpose -r -a email /bin/tar: 20120831115153: Cannot open: No such file or directory /bin/tar: Error is not recoverable: exiting now

It seems that the restore function doesn't properly get the last backup time.

Please, can you execute with bash -x zmbkpose -r -a email and send me the last lines previous to error

— Reply to this email directly or view it on GitHubhttps://github.com/bggo/Zmbkpose/issues/21#issuecomment-8455778.

liandros commented 12 years ago

The problem is caused by annoying debugging code. However the new branch "rewrite_proposal_v2.0" is immune to this. Additionally to give a complete solution to the problem, I created a new branch "issue_21". Please... use the code in the branch "issue_21". If the problem is solved, I will merge this on "rewrite_proposal_v2.0" branch.

marianstefan commented 12 years ago

Hello again,

The problem is solved now but others emerged while restoring: the script does no get the last backup cycle. So if only one FULL it returns "No backup files available for restoration", if two FULL backups it will restore the oldest backup. If 3 full backups it will restore oldest 2 FULL but not the last.

zimbra@mx01:/backup/admin@scsc.ro$ ls -lsah total 32K 4.0K drwxr-x--- 2 zimbra zimbra 4.0K 2012-09-17 15:54 . 4.0K drwxrwxrwx 4 root root 4.0K 2012-09-17 15:54 .. 12K -rw-r----- 1 zimbra zimbra 10K 2012-09-17 15:54 20120917155445:FULL.tar 12K -rw-r----- 1 zimbra zimbra 10K 2012-09-17 15:54 20120917155453:INC.tar 0 lrwxrwxrwx 1 zimbra zimbra 22 2012-09-17 15:54 LAST -> 20120917155453:INC.tar

+++ '[' '' = LAST -a -L /backup/admin@scsc.ro/LAST -a -f /backup/admin@scsc.ro/20120917155453:INC.tar ']' +++ '[' -z '' ']' +++ cat +++ /usr/bin/sort -r +++ cat +++ /usr/bin/find /backup/admin@scsc.ro -maxdepth 1 -mindepth 1 -type f +++ '[' '' = LAST ']' +++ '[' '' = FIRST ']' +++ cat ++ read date_time_mark full_inc bkfile ++ '[' -z 20120917155453 ']' ++ '[' 20120917155453 -gt 20120917160055 ']' ++ '[' -z '' -a INC '!=' FULL ']' ++ continue ++ read date_time_mark full_inc bkfile ++ '[' -z 20120917155445 ']' ++ '[' 20120917155445 -gt 20120917160055 ']' ++ '[' -z '' -a FULL '!=' FULL ']' ++ '[' -z '' ']' ++ cycles_to_maintain_reached=y ++ continue ++ read date_time_mark full_inc bkfile

liandros commented 12 years ago

Hello marianstefan. Thank you very much for your debugging and testing...

In restore, calling a erroneous function to get last cycle of backup. Was calling "get_backup_cycles_older_than" when it should call "get_last_backup_cycle_prior_to"

Branch issue_21 updated.
Please update you code with the last version of branch.

liandros commented 12 years ago

Thank marianstefan for your tests. I'll close for now this case.

sanjivbjoshi commented 10 years ago

hi I have installed Zmbkpose-rewrite_proposal_v2.0. Everything working fine except one thing and it is zmbkpose -backupdistributionlist command not working for backup all distribution list. So can you help me how to take backup of all distribution list. Already I have tried with following command zmbkpose -backupdistributionlist, zmbkpose --backupdistributionlist, zmbkpose -f -backupdistributionlist, zmbkpose -f --backupdistributionlist.

liandros commented 9 years ago

-backupdistributionlist is not a valid option . Try --help . There is no a option for backup only distribution lists. I will add thats in plans. Thanks

2014-11-05 4:32 GMT-03:00 Sanjiv Joshi notifications@github.com:

hi I have installed Zmbkpose-rewrite_proposal_v2.0. Everything working fine except one thing and it is zmbkpose -backupdistributionlist command not working for backup all distribution list. So can you help me how to take backup of all distribution list. Already I have tried with following command zmbkpose -backupdistributionlist, zmbkpose --backupdistributionlist, zmbkpose -f -backupdistributionlist, zmbkpose -f --backupdistributionlist.

— Reply to this email directly or view it on GitHub https://github.com/bggo/Zmbkpose/issues/21#issuecomment-61769607.