search

bghgary / glTF-Assets-Viewer

Tool for viewing multiple glTF files from a GitHub directory
MIT License
2 stars 2 forks source link

Change model orientation so it matches the sample screenshots #12

Closed stevk closed 5 years ago

stevk commented 5 years ago

Change to how the X value for the camera position is handled in the template strings. BabylonJS and ThreeJS use different coordinate systems, so inverting the X value is needed for one of them.

Because the screenshot generator uses BabylonJS but was not inverting the X position of the camera, the sample images didn't match the viewer versions of the same models. This corrects that discrepancy.

fixes https://github.com/KhronosGroup/glTF-Asset-Generator/issues/522

bghgary commented 5 years ago

The change should be on the screenshot generator side.