search

bghgary / glTF-Assets-Viewer

Tool for viewing multiple glTF files from a GitHub directory
MIT License
2 stars 2 forks source link

document.referrer use? #9

Closed donmccurdy closed 6 years ago

donmccurdy commented 6 years ago

Wondering what the purpose is for the document.referrer reference here...

https://github.com/bghgary/glTF-Assets-Viewer/blob/master/index.js#L220-L227

... as opposed to just hard-coding a URL. I guess that ensures links work on a branch? Not a big deal, but I tried to copy/paste links to demos out of a readme and was surprised when they didn't work when clicked from another site. :)

bghgary commented 6 years ago

Branch and most importantly PRs so reviews are possible. That was the fastest way I can think of to do it with markdown. There are probably better ways. The URL should be updated after you click the link, then you can copy it.

donmccurdy commented 6 years ago

Ok, seems as good as anything — thanks!