bgirard / GeckoProfiler

Mozilla's cross platform general purpose profiler with instrumentation hooks
1 stars 1 forks source link

Building with `SPS_STANDALONE` fails if `DEBUG` is defined #1

Open samgiles opened 8 years ago

samgiles commented 8 years ago

Building on Mac OS with #define DEBUG 1:

In file included from ../../external/mozprofiler/src/platform-macos.cc:40:
../../external/mozprofiler/src/platform.h:385:16: error: use of undeclared identifier 'NS_IsMainThread'
    MOZ_ASSERT(NS_IsMainThread());
bgirard commented 8 years ago

Ahh I haven't tried to build the debug configuration. I'll happily merge any patches to get this configuration working.

samgiles commented 8 years ago

Ok cool, I'll see what I can do when I get some time :). I've an elegant hack in my code for now s/DEBUG/_DEBUG/g ;).