bglandolt / bettercombat

Immersive Combat 1.12
Other
4 stars 3 forks source link

Substring not recognising weapons #42

Closed LuciferWPF910 closed 3 months ago

LuciferWPF910 commented 4 months ago

Hello,

I'm using mods that have flat ideas with no seperations. For example - cinderextras2:anubisdagger- When setting the substring to simply "dagger" it will not recognise the weapon as a dagger. Even when the substring is the full id without resource location "anubisdagger" it still doesn't recognise it.

I'm unsure whether this is a fault in my understanding or a potential issue with how it reads the substring. I'd love to suggest the ability to simply use resource locations as well as substrings, like in other parts of the code.

Xvareon commented 3 months ago

The anubis dagger probably isnt extended from sword or axe classes so its not being detected as a weapon

LuciferWPF910 commented 3 months ago

It is, I wrote the code for the mod and I have tried all other methods within the provided mod itself.

Xvareon commented 3 months ago

I see, if its extending from sword or axe classes, does the default knockback and critical chance show? meaning the mod recognizes it as a sword or axe. If it does, did you try to put the anubis dagger at the very front of the custom tweaker list in the configs?

LuciferWPF910 commented 3 months ago

I think a solution to this problem is just adding a feature to directly add specific weapons to a certain type. via modid:item_name