v1 tests failing, concept for splitting class

bglusman / debt_ceiling

Get a grip on your technical debt

MIT License

84 stars 7 forks source link

v1 tests failing, concept for splitting class #19

Closed bglusman closed 9 years ago

bglusman commented 9 years ago

@SeanMarcia as long as I'm piling review on you, what do you think of this refactor? It's not quite right as tests are failing (not sure why at a glance), and it also probably should change analysis so it will/can consider both seperate debt classes together for a single file or something, but I didn't like just pulling out the methods for a module as I did in the other branch, this is best idea for a cleaner refactor. Thoughts? Alternatives?

coveralls commented 9 years ago

Coverage increased (+0.1%) to 96.67% when pulling 45c8ff09330d22aa3cfd330f98b9cf99cfeaf4be on make_seperate_debt_classes into 14fd9e24c73fb5966ef6fdb0a0bcb05a227a9461 on conditional_multiplication_for_length.

bglusman commented 9 years ago

Closing in favor of #22, prefer composition over inheritance