search

bglusman / debt_ceiling

Get a grip on your technical debt
MIT License
84 stars 7 forks source link

Track todos #42

Closed bglusman closed 8 years ago

bglusman commented 8 years ago

@aribrenner we can also create a PR for this in gitcolony to compare but thought I'd start here... It's not quite ready to merge yet, but basics are working, feel free to play around or make suggestions!

bglusman commented 8 years ago

Resolves #43 when merged, and looks like gitcolony already picked this up automatically which is nice...

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.2%) to 87.435% when pulling 2e17ad80a5c10031a10cd46a60cbe3c89eb7fafd on track_todos into 9641edc1437cd59c6bfec5846ba97293b845ae30 on master.

bglusman commented 8 years ago

Oh, weird, debt scores are different on some rubies than others... leading some to fail via debt_ceiling self hosting, some to pass... probably a rubycritic issue, dunno...

Meanwhile, @aribrenner think we want to include a) line numbers, and/or b) git blame who committed that line so you have an idea who to talk to if considering it/want more info? I think it'd be nice/not too hard, but maybe that's a refinement once this is working OK for first release.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.9%) to 86.71% when pulling 9f7aa614522c1831b0f337fc956b011bc47dc622 on track_todos into 9641edc1437cd59c6bfec5846ba97293b845ae30 on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.4%) to 86.151% when pulling d0567971274358df23bb1e61dedac4c02e88c3ef on track_todos into 9641edc1437cd59c6bfec5846ba97293b845ae30 on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.6%) to 86.013% when pulling 4e12afe3078065dafd35823133e4ffa7ae616dd5 on track_todos into 9641edc1437cd59c6bfec5846ba97293b845ae30 on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.3%) to 84.249% when pulling a7daf8e9522304b844ee9172498c6e533b9ad3b2 on track_todos into 9641edc1437cd59c6bfec5846ba97293b845ae30 on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.6%) to 86.013% when pulling 037a9929fbdcaceac9f737ab266227d957f3eaec on track_todos into 9641edc1437cd59c6bfec5846ba97293b845ae30 on master.

bglusman commented 8 years ago

There's probably some code cleanup/tech debt here, but the API seems stable so let's call it good for now.

bglusman commented 8 years ago

OK, well, I merged this, tagged, released, and then it looked like there were errors installing and running on a real project outside the repo, and/or some conditions not tested where analysed_modules method was called on nil, so yanked release and killed the tag... will investigate and fix, but in case anyone was tracking this and waiting for a release on merge.