bgmgmbh / extension-bgm_hreflang

A TYPO3 extension to add hreflang meta tags: <link rel="alternate" hreflang="" href="" />
4 stars 12 forks source link

Deprecation of implode parameter order for PHP 7.4 #17

Closed dsone closed 2 years ago

dsone commented 3 years ago

Inside https://github.com/bgmgmbh/extension-bgm_hreflang/blob/master/Classes/Utility/HreflangTags.php#L190 the $this->renderedList = "\n" . implode($this->renderedListItems, "\n") . "\n"; uses a since PHP 7.4 deprecated parameter order: (array, glue)

For future compatiblity the parameter order needs to be reversed to comply with the correct signature: $this->renderedList = "\n" . implode("\n", $this->renderedListItems) . "\n";

See: https://www.php.net/manual/en/function.implode.php