search

bgmulinari / B1SLayer

A lightweight SAP Business One Service Layer client for .NET
MIT License
136 stars 47 forks source link

Added a POST method that returns only a string. #28

Closed GustavoArriola closed 1 year ago

GustavoArriola commented 1 year ago

Added a POST method that returns only a string. It's usefull when you are using a service like 'SBOBobService_GetSystemCurrency'. This service just returns a string, while the default PostStringAsync () make a json convertion that returns an exception.

bgmulinari commented 1 year ago

Hi, @GustavoArriola. Thanks for your PR.

I think this is a good addition as this is a scenario I hadn't considered. However, the only issue I have with your commit is the name of the method, because unlike the other PostStringAsync overloads, in your case you are not actually posting a string, but rather receiving one. With that said, I think a more suitable name for it would be PostReceiveStringAsync.

GustavoArriola commented 1 year ago

Thanks @bgmulinari for your comment! I made the change. Regards!

bgmulinari commented 1 year ago

@GustavoArriola, I will be merging this PR into the dev branch, so this change should be made available in the next B1SLayer release.

Thanks for your contribution! 👍

bgmulinari commented 1 year ago

This change is now available in version 1.3.0.