search

bgnerdclub / birb

6 stars 0 forks source link

Jake logs(Rev.1) #3

Closed mavic7 closed 6 months ago

mavic7 commented 6 months ago

Ready for code review and discussion before merge

Alex-Programs commented 6 months ago

I like the system you've setup, but I'd like to try to make it more ergonomic by passing a reference to self instead of an ID then using https://doc.rust-lang.org/std/any/fn.type_name.html on it to get the module name.

Alex-Programs commented 6 months ago

We've also got a conflict on cargo.lock - shouldn't that be in the .gitignore?

The guidelines are that libs shouldn't check it in, but applications should. This is a library (or at least moreso than an application) and so cargo.lock shouldn't be in the VCS. Probably best to wipe it from git history while we're at it - afaik it's not specific to this branch.

jw2476 commented 6 months ago

It should, for some reason cargo didn't put it there, that's going to be fun to delete

mavic7 commented 6 months ago

Closing this PR so that I can reopen when suggestions have been implemented, and to try and sort out this weird cargo.lock config issue.