Consider 'claiming' a prometheus port allocation for stayrtr/rtrmon

bgp / stayrtr

RPKI-To-Router server implementation in Go

BSD 3-Clause "New" or "Revised" License

91 stars 13 forks source link

Consider 'claiming' a prometheus port allocation for stayrtr/rtrmon #10

Closed ties closed 2 years ago

ties commented 3 years ago

As a user [running stuff on metal/vms, not on k8s], to prevent the daemon overlapping with other ports, it would be helpful if stayrtr had an allocated port for it's prometheus endpoints.

To do so, reserve one in https://github.com/prometheus/prometheus/wiki/Default-port-allocations

job commented 3 years ago

Feel free to claim one, and submit a PR here

randomthingsandstuff commented 3 years ago

Yeah, what job said + if I don't get around to it before you do anyway. Laziness says "I coulda just done it while I wrote this comment, ah whatever" though.

randomthingsandstuff commented 3 years ago

9847 claimed in that wiki. Guess we just need to update things.

job commented 2 years ago

Fixed in https://github.com/bgp/stayrtr/commit/876179b0d9a9a47d44077fb6720c6f3a40be59f8 and https://github.com/bgp/stayrtr/commit/580a914a0178a457e42b3ea8fd1a83e98c1a6406