search

bgp / stayrtr

RPKI-To-Router server implementation in Go
BSD 3-Clause "New" or "Revised" License
85 stars 13 forks source link

Remove the AFI dependency for ASPA #105

Closed cjeker closed 6 months ago

cjeker commented 7 months ago

The AFI was removed from the ASPA profile so don't expect it anymore. Now RTR is still using an old idea of ASPA profile so there just duplicate the object once for IPv4 and once for IPv6. At some points SIDROPS may finally fix this but for now this allows to export ASPA objects that follow the rpki-client JSON (which no longer has the AFI in the ASPA table).

I'm not certain about the changes to slurm but I think it should be fine. With this stayrtr is able to distribute the ASPA records from the default cache file.

benjojo commented 7 months ago

We might want to hold merging this until https://github.com/bgp/stayrtr/pull/103 is done, since that is a much more complex PR that might conflict

benjojo commented 7 months ago

Also it's currently very up in the air on what draft-spaghetti-sidrops-aspa-slurm has to say about this output.

cjeker commented 7 months ago

I'm happy to rebase this once #103 is merged as long as #103 is merged soon. Right now the ASPA support in stayrtr is broken since rpki-client changed the JSON format some time ago but this code was never adjusted. This was all triggered by this bug report https://github.com/openbgpd-portable/openbgpd-portable/issues/71

cjeker commented 6 months ago

Rebased after merge of #103

ties commented 6 months ago

@cjeker do you think there is a reasonable way to have a compatibility mode for both routinator's and rpki-client's output? Ideally we would align those of course.

benjojo commented 6 months ago

Do you have an example of routinator output on hand?

job commented 6 months ago

What’s the point though? R3000 already has a built-in RTR server.

cjeker commented 6 months ago

I would prefer if routinator would follow the JSON structure of rpki-client for ASPA objects. The old format with the AFI is dead. It makes no sense to try to support it in my opinion.