bgp / stayrtr

RPKI-To-Router server implementation in Go
BSD 3-Clause "New" or "Revised" License
85 stars 13 forks source link

Naming is hard #107

Closed cjeker closed 6 months ago

cjeker commented 6 months ago

Cleanup some code that is just confusing because the variables and functions are inappropriately named. While I can handle ROA vs VRP and ASPA vs VAP, it breaks my mind when VRP refers to all objects in the cache.

Mainly use RPKI for the top level structure that includes VRP, VAP and BgpsecKeys. Use VAP instead of aspa (at least in those places where VRP is used instead of ROA). Use items for SendableData objects since those can be VRP, VAP or BgpsecKeys. Kill a unused function and variable in the server code.