search

bgp / stayrtr

RPKI-To-Router server implementation in Go
BSD 3-Clause "New" or "Revised" License
85 stars 13 forks source link

Cleanup server code a bit #111

Open cjeker opened 6 months ago

cjeker commented 6 months ago

Some random cleanup while beating my head against the draft-ietf-sidrops-8210bis wall

benjojo commented 6 months ago

But that has to be counterbalanced against basically breaking everybody's upgrades and forcing people to change their config

On Tue, Jan 16, 2024, 10:13 Claudio Jeker @.***> wrote:

@.**** commented on this pull request.

In cmd/stayrtr/stayrtr.go https://github.com/bgp/stayrtr/pull/111#discussion_r1453210161:

@@ -53,10 +53,15 @@ var (

ExportPath = flag.String("export.path", "/rpki.json", "Export path")

  • RTRVersion = flag.Int("protocol", 2, "RTR protocol version. Version 2 is draft-ietf-sidrops-8210bis-10")
  • RTRVersion = flag.Int("rtr.protocol", 2, "RTR protocol version. Version 2 is draft-ietf-sidrops-8210bis-10")

I think there is some benefit in doing this but I can split out this part of the change into an extra PR. Right now the stayrtr arguments are a hodgepodge.

— Reply to this email directly, view it on GitHub https://github.com/bgp/stayrtr/pull/111#discussion_r1453210161, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALPK4WB47DALFMVGDWU3H3YOZHEDAVCNFSM6AAAAABB3KSYEGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMRSHE3TSMBTGU . You are receiving this because you commented.Message ID: @.***>

cjeker commented 6 months ago

But that has to be counterbalanced against basically breaking everybody's upgrades and forcing people to change their config

This is something that can be clearly communicated in the release notes. In the mean time I reverted that bit we can cycle back to that later.